[stephrobert]

Summary

Ten payload fixtures under tools/ci/testdata/race-night-*/ reached main through #926 without a final newline. The repository's own end-of-file-fixer hook rewrites them on every commit, sees files it modified, and exits 1.

So every push from any clone where pre-commit install has been run fails, on a diff that has nothing to do with the files the hook names.

One byte per file. The ten documents still parse, and go test ./tools/ci/ is green before and after.

Measured

Three times today, on three different branches:

• the contributor's own branch of fix(ci): the night report judges only its declared jobs (#830) #926, which is where the files come from;
• twice more on unrelated lots whose own files were all correct, where the hook's output ends failed to push some refs after naming ten fixtures the lot never touched.

That is what makes it expensive rather than trivial: the symptom points at the wrong change, so the diagnosis is paid again each time.

Why CI never caught it

pre-commit runs in no workflow, and that is deliberate: a red over documentation freshness in CI teaches --no-verify, which disarms every other hook at once. CONTRIBUTING.md states the reasoning.

The cost of that choice is exactly this case. A file the hook refuses can reach main through a green pull request, and then block everybody's push until somebody reads the hook's output carefully enough to notice the named files are not theirs. Worth knowing; not worth putting pre-commit in CI over.

Related: #936 already carries the other half of this, that falsify:lint and falsify:selftest are run by no pull request while CONTRIBUTING.md says prepush is what a pull request refuses.

Type of change

• Bug fix
• A route added or changed
• Refactor
• Documentation
• Chore / tooling
• Security / supply chain

Runs

run	verdict
go test ./tools/ci/	green, before and after
the pre-commit suite, through the commit itself	green, and it rewrites nothing now

Mode: --vm off. Nothing here touches a route, a response shape or a machine runtime, so no leg and no FEINT_VM run is owed. mise run testplan routes tools/ci/** to the Go suite, which is green.

No contradicteur was asked: the diff is one trailing byte per file, the hook that demands it is the measurement, and the ten documents are asserted to still parse.

Checklist

Always

• mise run check passes
• No new external Go dependency
• internal/core still knows no provider
• Nothing in the diff could be written identically for another provider
• mise run testplan was run, and what it printed was run

When a model wrote a substantive part of this

• An Assisted-by: trailer names the tool and the model version
• No field name and no response shape changes

When a route is added or changed

N/A.

When behaviour a client can observe changes

N/A.

When .github/workflows/ is touched

N/A.

When a machine runtime is involved

N/A.

Related issues

None. This is the repair of a push-blocking artefact of #926, not an issue anybody filed.

🤖 Generated with Claude Code