Repository navigation
Keep the canvas anchored beneath the pointer when zooming - #250
Open
stevebauman wants to merge 1 commit into
Open
stevebauman wants to merge 1 commit into
stevebauman wants to merge 1 commit into
Conversation
Deploying showcode with
|
| Latest commit: |
d7945af
|
| Status: | 🚫 Build failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pinching over the canvas could still move the content away from your mouse. The zoom library measures the focal point from the surrounding area, but our canvas wrapper was a smaller element centered inside that area, which offset its calculations.
I've made the zoom wrapper fill the preview area while keeping the canvas centered at its configured size. The point beneath your mouse now stays in place as you zoom, including after panning and at the zoom limits.
Verified in Chromium with small and oversized canvases: the original layout drifted roughly 49px horizontally and 71px vertically from one pinch; the updated layout stayed within 0.001px across 12 zooms. All 160 tests pass.