feat: lean-loop — closeout collapse, triage slimming, ac-convention split, audit scope + brace-glob fixes, standard eval arm - #15
Merged
Merged
Conversation
…als can't PASS (AC-4, lean-loop)
…r silently denies (AC-5, lean-loop)
…d in, iters optional (AC-1, lean-loop)
…erences/, worked-examples table dropped (AC-2, lean-loop)
…y, examples to test-gen (AC-3, lean-loop)
…VAL-DONE finish line (AC-6, lean-loop)
… in lcd rule, Test scope in plan template (lean-loop)
… (audit binding) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2nUKdedKjWZLeS3hpFJXk
…cost, quality parity (69-71/75) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2nUKdedKjWZLeS3hpFJXk
…d prompt (evaluator nit) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H2nUKdedKjWZLeS3hpFJXk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Acts on the three-reviewer over-engineering audit of LCD (two independent Opus 5 reviewers + a Fable fork, cross-examined to consensus; harness work-item
lean-loop). The audit's verdict: the architecture is sound, but weight concentrated at the work-item finish line and on triage's hot path, plus two verified defects and one missing benchmark arm.The five changes
lcd-triage-log.sh closeoutappend, with the opt-in evaluator dispatch folded in before it and the opt-in living-spec fold after it (D-022 ordering preserved).--itersbecomes optional;--lane/--audit/--reroutes/--interventionsstay mandatory. Both closeout line shapes validate; existing logs are never rewritten;/lcd:tidyreads both.skills/triage/SKILL.mdslimmed 1,931 → 935 words on the every-item path: lane bodies →references/lanes.md(read only for the routed lane), re-routing →references/rerouting.md, worked-examples table dropped, soft-proxy rationale deduplicated to a pointer atrules/lcd.md./lcd:specifyand the worked examples to/lcd:test-gen.**Test scope:**; the audit'sAC-N (SURFACE)test grep is then confined to those paths, so a stale literal left by another work-item (the recorded T1 false-positive) can never produce an OK row. Declared-but-missing scope is a miss, never a fallback; scope-less plans keep legacy behavior.{a,b}EDIT BOUNDARY entries are brace-expanded before thecasematch (lcd_expand_braces), closing the silent-denial hole open since 0.15.1. Original entry kept in the deny reason.Plus: the missing benchmark arm (AC-6)
evals/run-eval.sh --triage-routed— a frozen prompt (feature-prompt-standard.md, feature paragraph identical to the Deep arm's) that routes throughlcd:triageand never names an expected lane, with a lane-agnosticEVAL-DONEfinish line. The T1 campaign priced only the mandated-Deep arm; this arm measures what triage actually picks and what that lane costs. Grader and golden dataset untouched.Tests
TDD throughout:
tests/test-lean-loop-fixes.sh(new; carries the AC-1/4/5 fixtures, red-first) + extendedtests/test-eval-runner.sh. Suite 13/13 green.🤖 Generated with Claude Code
https://claude.ai/code/session_01H2nUKdedKjWZLeS3hpFJXk