Repository navigation
Fix Mint infrastructure scope test on main pushes - #75
Merged
Merged
Conversation
rdpollard
commented
Oct 18, 2026
rdpollard
left a comment
Member
Author
There was a problem hiding this comment.
Reviewed c6c36fc: the change only isolates a mocked test from inherited GitHub push metadata and corrects its name. Reproduced the previous failure and verified all 12 local scope/inventory tests with the same outer main-push metadata. No classifier or access-policy changes. Policy/scope/workflow/Windows CI pass; waiting for Mint fixture CI before merging. Activation variables, runner registration/start and workflow dispatch remain untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI scope-policy test inherited real
GITHUB_REF,GITHUB_SHAand push metadata on main. Its mocked non-PR scenario therefore entered the legitimate infrastructure-only main-push branch and failed a test assertion. PR CI had passed because its inherited ref was a PR ref.Clear the environment for that scenario and rename it to state the actual missing-main-metadata condition. No production classifier, activation gate or runner workflow changes. Reproduced the pre-fix failure using a synthetic main-push payload, then verified all 9 scope tests pass with those same enclosing environment variables; the 3 inventory policy tests and actionlint also pass.
This follow-up repairs #74's post-merge checks. Runner activation variables remain untouched; no registration/start, dispatch, guest test, application build/package or release operation is added. PR #73 remains draft/unmerged. The exact infrastructure path remains classified as application CI not required.