Skip to content

Fix Mint infrastructure scope test on main pushes - #75

Merged
rdpollard merged 1 commit into
mainfrom
fix/mint-inventory-main-tests
Oct 18, 2026
Merged

rdpollard merged 1 commit into
mainfrom
fix/mint-inventory-main-tests

Conversation

@rdpollard

Copy link
Copy Markdown
Member

The CI scope-policy test inherited real GITHUB_REF, GITHUB_SHA and push metadata on main. Its mocked non-PR scenario therefore entered the legitimate infrastructure-only main-push branch and failed a test assertion. PR CI had passed because its inherited ref was a PR ref.

Clear the environment for that scenario and rename it to state the actual missing-main-metadata condition. No production classifier, activation gate or runner workflow changes. Reproduced the pre-fix failure using a synthetic main-push payload, then verified all 9 scope tests pass with those same enclosing environment variables; the 3 inventory policy tests and actionlint also pass.

This follow-up repairs #74's post-merge checks. Runner activation variables remain untouched; no registration/start, dispatch, guest test, application build/package or release operation is added. PR #73 remains draft/unmerged. The exact infrastructure path remains classified as application CI not required.

@rdpollard rdpollard left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed c6c36fc: the change only isolates a mocked test from inherited GitHub push metadata and corrects its name. Reproduced the previous failure and verified all 12 local scope/inventory tests with the same outer main-push metadata. No classifier or access-policy changes. Policy/scope/workflow/Windows CI pass; waiting for Mint fixture CI before merging. Activation variables, runner registration/start and workflow dispatch remain untouched.

@rdpollard
rdpollard merged commit 28fb4d0 into main Oct 18, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant