Skip to content

Replace square application icon with supplied rounded-square artwork - #84

Merged
rdpollard merged 1 commit into
mainfrom
ui/rounded-application-icon
Oct 19, 2026
Merged

rdpollard merged 1 commit into
mainfrom
ui/rounded-application-icon

Conversation

@rdpollard

@rdpollard rdpollard commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

The owner reported all v1.2.10 UAT rows Pass on Windows 11 and Mint Cinnamon, then rejected the perfectly square white icon tile. Use their supplied skyview_logo_rounded_square.svg for all packaged PNG/ICO sizes, preserving its rounded white tile and transparent exterior. The shared in-app logo and runtime UI are unchanged.

Record the owner's aggregate acceptance without inventing OS/webview/scale or per-tool details. Accepted theme/zoom/guidance issues #4/#5/#6 are closed; #63 and the milestone stay open for focused native acceptance of the new icon. Add fixed v1.2.11 support to the protected candidate workflow and a short installation/icon results sheet. The 1.2.10 upgrade package is an unpublished same-source fixture; published v1.2.10 assets remain unchanged.

Related: #63. No automatic issue closure on merge. Stable promotion and fleet rollout remain separate.

Validation:

  • Supplied SVG retained byte-for-byte (SHA-256 ef5a1667a5265bd4c1d5c53340851d5898f49068c19ceb7aff7be534aca3b68d). Visually inspected its render and 32/48/64px previews on dark/light backgrounds.
  • Three PNGs retain RGBA, transparent exterior corners, white tile interior and antialiased edges. All six ICO sizes retain rounded alpha edges; 16px corners preserve partial curve coverage. Repeated generation with the same tools gives identical hashes after stripping metadata.
  • Candidate identity/baseline/dependency preservation and nine CI scope tests pass; actionlint, generator ShellCheck/Bash syntax, document links and whitespace pass.
  • All 256 selection combinations checked for the mutually exclusive dispatch guard; all eight candidate routes, default and PR pair expressions checked.
  • Full CI and actual Windows SYSTEM / Mint root 1.2.10 -> 1.2.11 upgrade probes passed on the final reviewed head.

Final-source verification

Reviewed head: f2c5fc03784df1c6f59ba8f632b7875932842328.

v1.2.11 published authentication receipt

Merged source: 792f0dc6c4b39a856b23be5fc656e12ed06ae63f (tree 0f167985826adca5fdfe439165e6fbc6cd844d74, identical to reviewed head f2c5fc03784df1c6f59ba8f632b7875932842328).

Protected candidate run: https://github.com/stormbots/Tactics-Strategy-Dev-Environments/actions/runs/39336851263 — rounded_icon=true, all seven legacy options false, publishes only v1.2.11. The v1.2.10 installers are unpublished same-source upgrade fixtures.

Exact-main verification: https://github.com/stormbots/Tactics-Strategy-Dev-Environments/actions/runs/39336773988

Supplied SVG SHA-256: ef5a1667a5265bd4c1d5c53340851d5898f49068c19ceb7aff7be534aca3b68d. The source bytes are preserved unchanged.

Exact-main full CI passed. Both actual Windows SYSTEM and Mint root 1.2.10 -> 1.2.11 upgrades passed in the candidate run.

Owner signing approval cleared the protected environment. The complete candidate run succeeded, including downloading and authenticating the published assets. v1.2.11 was published at 2026-10-19T23:08:43Z as a non-draft prerelease. The release tag resolves to the exact merged source above.

Build inputs (unexpired run-bound artifact ZIP archives; these are archive digests, not installer hashes):

Publication and authentication are confirmed; focused owner icon UAT may begin. Codex independently downloaded exactly the expected five assets, verified the manifest signature using the repository-pinned production key, authenticated both installers, passed sha256sum --check SHA256SUMS.txt, and matched every file size and SHA-256 to GitHub release asset metadata. The Linux DEB identity is skyview-dev-setup / 1.2.11 / amd64; all three packaged icon sizes match the reviewed rounded assets pixel-for-pixel. Focused installation/icon UAT sheet. Prior v1.2.10 published assets were checked unchanged.

This receipt supplies the publication confirmation required by the UAT guide’s preparation-only heading and pending handoff cells. Desktop installation, revised icon shape, taskbar/dock and shortcut-cache acceptance remain owner UAT. #4/#5/#6 are accepted and closed; #63 and the milestone remain open until the revised icon is accepted.

Published SHA-256 values:

Asset SHA-256
SHA256SUMS.txt d3bd2ac1224c834a7538ac6bb5f04c4d1cda8c09d8426faf05ec400f309b5e98
Skyview-Dev-Setup-LinuxMint-amd64.deb c2823232f2de28e7866c9aa533043a802b877deb5b1dea86e5a801c745752ec6
Skyview-Dev-Setup-Windows-x64.exe fbe1ae83243315962bd93f89b83e060166e78465ad34b4dba6511ed61fbb8996
sde-update.json 549dc343c826964125bf711a232844af4b2e6851434d51973e3f0d62e616c1a6
sde-update.json.minisig 2dd8f3a35740492f603e23a959fd6c723790c0fb5a12a63296329477d13fe2ba

@rdpollard
rdpollard merged commit 792f0dc into main Oct 19, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant