fix: support multiple foundational stores - #947
Closed
driescroons wants to merge 1 commit into
Closed
driescroons wants to merge 1 commit into
driescroons wants to merge 1 commit into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Hey, was this an agentic mistake or something else? Happy to update skills/docs if it was, to Unless it's something else …? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Modules can declare multiple foundational-store inputs, and the WASM runtimes assign each input its own index. The server only wired clients from the first input, so accessing index 1 failed with
invalid foundational store index 1, 1 stores declared.Fix
Wire exactly one client for each foundational-store input in declaration order. Reject unsupported client cardinality before execution instead of silently corrupting guest indexes.
Verification
go test ./pipeline/...go vet ./pipeline/...go build ./...git diff --check