highlight kerbs - #7040
highlight kerbs#7040paulklie wants to merge 1 commit into
Conversation
|
have you tested it with https://wiki.openstreetmap.org/wiki/Key:kerb mentions stuff like adding |
westnordost
added
the
feedback required
|
am waiting for answers from @peternewman since they requested this change. |
| if (!crossingFilter.matches(element)) false else null | ||
|
|
||
| override fun getHighlightedElements(element: Element, mapData: MapDataWithGeometry) = | ||
| mapData.filter("nodes, ways with kerb or barrier=kerb") |
There was a problem hiding this comment.
| mapData.filter("nodes, ways with kerb or barrier=kerb") | |
| mapData.filter("nodes, ways with kerb or barrier = kerb") |
| } | ||
|
|
||
| override fun getHighlightedElements(element: Element, mapData: MapDataWithGeometry) = | ||
| mapData.filter("nodes, ways with kerb or barrier=kerb") |
There was a problem hiding this comment.
| mapData.filter("nodes, ways with kerb or barrier=kerb") | |
| mapData.filter("nodes, ways with kerb or barrier = kerb") |
| } | ||
|
|
||
| override fun getHighlightedElements(element: Element, mapData: MapDataWithGeometry) = | ||
| mapData.filter("nodes, ways with kerb or barrier=kerb") |
There was a problem hiding this comment.
| mapData.filter("nodes, ways with kerb or barrier=kerb") | |
| mapData.filter("nodes, ways with kerb or barrier = kerb") |
I'm not sure what answers you require from me @paulklie ? It looks like I was the last to reply on the linked issue? The only minor oddity I mentioned there was that a node tagged with highway=crossing and kerb= rendered as both kerb and crossing in pink in your preview before, such as this one, unhelpfully now deleted: Plus the stretch goal/future enhancement of how best to show it on a way (e.g. should it repeat the symbol along the way's length) and the challenge of a node (which is also a kerb) intersecting with the way, but I still personally feel it's a sufficient improvement they could be later fixes. I'm also still not sure it needs adding to AddCrossingKerbHeight as the question is then about a crossing (not a kerb) node, plus in theory it shouldn't be asked there, although personally I'm not entirely certain that filtering is working as intended. But there's probably no harm given you could have some complicated interplay with adjacent cycle land crossings. |
5 participants
Implements #6525
Kind of forgot this one, it highlights other kerbs while answering a kerb related quest. Making it easier to guage which height other users have answered.
ping @peternewman