Allow the tactile_paving quest to be answered once for the whole crossing

[leijurv]

Context: #3407 (comment) I hope that this can be considered anyway 🙏

While editing with StreetComplete, I wished that I could answer Does this crosswalk have tactile paving on both ends? in the affirmative and have it put tactile_paving=yes on not just the highway=crossing but also on both highway=kerb connected by footway=crossing.

With this PR, there is only one such tactile paving quest visible, which is the one on the crossing node. If you answer "yes (both)", it tags all three as yes. If you answer "no (not both)", the quests on each kerb will appear and you can answer those individually.

Undo works properly. I have loaded this as an .apk onto my phone to make sure it does it right. Unit tests added too.

[paulklie]

So from my understanding, if a user answers the tactile paving quest, the answer is applied to all similar quests in a 100meter radius?

That seems like it could lead to a lot of bad data to me.

[leijurv]

@paulklie @matkoniecz Oh no, surely not! That would indeed result in a lot of bad data.

100 meters is just the radius from which it fetches data. We carefully look from the highway=crossing node for the connected footway=crossing, then we take the first and last nodes of that way, only if they are tagged barrier=kerb. Only then does it write tactile_paving=yes to the kerb nodes, and only if you answered yes. If you put no or incorrect, nothing happens to the kerbs.

[westnordost]

Could you state in what capacity you used AI to create this PR, if any? Did you review it?

It's a big PR which adds a powerful new capability. I can't say when I get to review this one properly. From a cursory look, I am wary to change that quests only concern themselves with one element because

• so far the whole code is written with the assumption that quests always just refer to one element. I can't assess right now what all would need to be changed when that assumption is broken

• I fear it may open a can of worms for similar additions. This is not bad per se, just as the idea of this PR is also quite good - to remove superfluous quests - ; and it may be an avenue to enable quite a bit more useful quests involving various elements (turn restrictions, maybe??). I'd just like to know beforehand what we are getting into

[leijurv]

That is all very reasonable thank you.

Yes entirely written by AI. I did read it and tested several versions on my actual phone to ensure it does what I want. I can show a screen recording if you like.

That's understandable that it would need your considered review but that it's also intriguing for more sophisticated quests.