Conversation
westnordost
requested changes
Sep 13, 2026
westnordost
left a comment
westnordost
left a comment
Member
There was a problem hiding this comment.
Please have a look at for example AddCyclewayForm how this is done:
I.e. pass the element, parse it in AddRecyclingContainerMaterialsForm in a remember(!!) and the selectedItems must only be remembered then for the given originalItems.
Also, RecyclingContainerMaterials.parseRecyclingMAterialsfunction is inconsistent, put it into an own file, just like with all the other parsers.
What happens when plastic but also plastic_bottles is selected? Will the form be able to deal with it? How will it deal with it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #7027
I forgot the recycling materials quest.
Tested