Skip to content

feat: Enhance Stride.Launcher - #3383

Merged
xen2 merged 38 commits into
stride3d:masterfrom
Jklawreszuk:launcher
Sep 17, 2026
Merged

xen2 merged 38 commits into
stride3d:masterfrom
Jklawreszuk:launcher

Conversation

@Jklawreszuk

@Jklawreszuk Jklawreszuk commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

PR Details

This PR includes a list of visual improvements related to Stride.Launcher, designed to improve its appearance and ensure it blends in better with the Fluent2 design, from which Avalonia draws its inspiration:
Source: https://fluent2.microsoft.design/

image

Features

  • Implement/Port custom TitleBar from WPF Launcher
  • Add icons for "Getting Started" and News Tab
  • Add icon for News cards
  • Add styling for "primary" button
  • Unify colors and some transparency for buttons
  • Small margin/padding tweaks, few refactoring changes for styles
  • Set minimum size for Window
  • Stretch community buttons
  • Rounding corners for cards
  • Add some text when synchronizing

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Jklawreszuk
Jklawreszuk marked this pull request as draft August 31, 2026 23:42
@github-actions

Copy link
Copy Markdown
Contributor

🤖 Draft PR — automatic CI is skipped to save runner minutes.

  • Mark the PR ready for review to run the full automatic CI — or add a ci-run-on-draft label to run it now without leaving draft.
  • Or arm a specific opt-in suite: ci-enduser, ci-editor, ci-ios, ci-android.

@Kryptos-FR Kryptos-FR changed the title feat: Enchance Stride.Launcher feat: Enhance Stride.Launcher Sep 1, 2026
@Jklawreszuk
Jklawreszuk force-pushed the launcher branch 3 times, most recently from ecce7f7 to ab630b5 Compare September 2, 2026 09:48
Comment thread sources/launcher/Stride.Launcher/Views/MainView.axaml
@Jklawreszuk

Copy link
Copy Markdown
Collaborator Author

Well, I'm not sure if the code is the most elegant, but I did the best I could. The changes are ready for review. @Kryptos-FR

@Kryptos-FR Kryptos-FR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really agree with the changes. I will need more explanations for them.

Comment thread sources/Directory.Packages.props Outdated
Comment thread sources/launcher/Stride.Launcher/App.axaml.cs
Comment thread sources/launcher/Stride.Launcher/Views/MainView.axaml.cs
@Jklawreszuk
Jklawreszuk force-pushed the launcher branch 2 times, most recently from 0128385 to 548ee44 Compare September 14, 2026 03:29
@Jklawreszuk

Jklawreszuk commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator Author

To be honest, I had no vision with light theme, so It made me think, "Hey, since the buttons are transparent now, we can consider this both a light and a dark theme isn't it?" Also It was something off with the previous light theme, but I guess It was simply background which was too much dark indeed. So I will try to think liltle bit longer about light theme.

@Kryptos-FR

Copy link
Copy Markdown
Member

I'm replacing some of the images with vector images. This should work better with dark/light theme.

@Kryptos-FR

Kryptos-FR commented Sep 15, 2026

Copy link
Copy Markdown
Member

I think I came up with a good compromise for the light theme. It's definitely better than before. There are still a few icons to replace with vertex geometry.

Dark:
image

Light:
image

@Jklawreszuk

Copy link
Copy Markdown
Collaborator Author

I am not sure what to think about the button background change, but we can always reiterate by making another PR 😅. Overall I would say its 100% better with these new vector icons. The only this is missing icons for "Projects" and "Switch/update version". Other than that, I have no comments.

@xen2

xen2 commented Sep 16, 2026

Copy link
Copy Markdown
Member

@Kryptos-FR I think we'll want a new launcher release soon with all the changes (.NET 11, hiding 4th digit in version numbers for 4.4+, and I think there were a few other important bits to support 4.4 well)

Should we merge this in before final testing?

Maybe need to fix #3438 as well?
CrashReporter better stay in-process, right? (it's not like we load native libraries so it should be only .NET unhandled exception, easy to handle)

Also normalize resource keys and classes naming.
@Kryptos-FR

Copy link
Copy Markdown
Member

@xen2 I have 4 more images to replace with vector graphics. I already added a fix for #3438 in this branch (with a MaxWidth). For wrapping I need to check the behavior in MarkView.Avalonia since we use a markdown viewer for the content.

We can keep the crash reporter in process for now. I'll need more time to find a proper solution (if any is needed).

Should we retarget this PR to master-4.4?

@VaclavElias

Copy link
Copy Markdown
Contributor

Light theme looks also nice.

@Kryptos-FR

Kryptos-FR commented Sep 16, 2026

Copy link
Copy Markdown
Member

Remaining icons converted. @xen2 ready to be tested and merged if no issues.

edit: I tried to pack the Launcher and add it to the local NugetDev. The old launcher picked up the update and then nothing. I'm not sure the current publish profile is working as expected.

edit2: my bad. I did not run -t:BuildLauncher before -t:PackageLauncher so my initial build wasn't single file.

@Kryptos-FR
Kryptos-FR changed the base branch from master to master-4.4 September 16, 2026 12:47
@xen2

xen2 commented Sep 16, 2026

Copy link
Copy Markdown
Member

We can keep the crash reporter in process for now. I'll need more time to find a proper solution (if any is needed).

Yes, I think it works fine for our purpose as it is (pending final testing on real package).
No need to make it much more complex for cases we don't need (native crash, etc.).

I'd rather keep time/energy to focus on the launcher itself, Avalonia port, 4.4 release, 4.5, etc.

@ferafiks

Copy link
Copy Markdown
Contributor

Light mode is less readable than dark. It could be improved if the background image had boosted dark levels and a blur, similarly to the dark version. Here's a rough version of that, I don't have much time right now to build and test it:

image

@Kryptos-FR

Copy link
Copy Markdown
Member

@ferafiks I have actually "lighten" the original image.

@xen2
xen2 changed the base branch from master-4.4 to master September 17, 2026 13:33
@xen2
xen2 merged commit fecd945 into stride3d:master Sep 17, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants