feat: Enhance Stride.Launcher - #3383
Conversation
|
🤖 Draft PR — automatic CI is skipped to save runner minutes.
|
ecce7f7 to
ab630b5
Compare
f2ef068 to
7708039
Compare
abac383 to
284c106
Compare
|
Well, I'm not sure if the code is the most elegant, but I did the best I could. The changes are ready for review. @Kryptos-FR |
Kryptos-FR
left a comment
There was a problem hiding this comment.
Don't really agree with the changes. I will need more explanations for them.
0128385 to
548ee44
Compare
|
To be honest, I had no vision with light theme, so It made me think, "Hey, since the buttons are transparent now, we can consider this both a light and a dark theme isn't it?" Also It was something off with the previous light theme, but I guess It was simply background which was too much dark indeed. So I will try to think liltle bit longer about light theme. |
|
I'm replacing some of the images with vector images. This should work better with dark/light theme. |
0a2c783 to
299b200
Compare
|
I am not sure what to think about the button background change, but we can always reiterate by making another PR 😅. Overall I would say its 100% better with these new vector icons. The only this is missing icons for "Projects" and "Switch/update version". Other than that, I have no comments. |
|
@Kryptos-FR I think we'll want a new launcher release soon with all the changes (.NET 11, hiding 4th digit in version numbers for 4.4+, and I think there were a few other important bits to support 4.4 well) Should we merge this in before final testing? Maybe need to fix #3438 as well? |
Also normalize resource keys and classes naming.
|
@xen2 I have 4 more images to replace with vector graphics. I already added a fix for #3438 in this branch (with a We can keep the crash reporter in process for now. I'll need more time to find a proper solution (if any is needed). Should we retarget this PR to |
|
Light theme looks also nice. |
|
Remaining icons converted. @xen2 ready to be tested and merged if no issues. edit: I tried to pack the Launcher and add it to the local NugetDev. The old launcher picked up the update and then nothing. I'm not sure the current publish profile is working as expected. edit2: my bad. I did not run |
Yes, I think it works fine for our purpose as it is (pending final testing on real package). I'd rather keep time/energy to focus on the launcher itself, Avalonia port, 4.4 release, 4.5, etc. |
|
@ferafiks I have actually "lighten" the original image. |



PR Details
This PR includes a list of visual improvements related to Stride.Launcher, designed to improve its appearance and ensure it blends in better with the Fluent2 design, from which Avalonia draws its inspiration:
Source: https://fluent2.microsoft.design/
Features
Types of changes
Checklist