Offer all sync targets in first-run setup - #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First-run setup offered Garmin and Strava, so someone who wanted only Zwift had to discover a separate command and enable scheduling manually. The wizard now offers all three targets before requesting service credentials, accepts any nonempty combination, and reaches the existing scheduling offer after a successful first sync. Zwift remains experimental and opt-in.
Both setup entry points share the existing Zwift validation and credential-storage logic. Failed validation leaves the configuration and unrelated credentials untouched, and its recovery command matches the setup flow being used.
The README is shorter and links to guides for commands, Linux scheduling, and troubleshooting. Factual corrections cover repair scope, raw versus processed Eufy data, and Strava API-app eligibility. A CI badge and focused bug-report form make the repository easier to use. Version 1.13.1 includes the onboarding fix and updated package documentation.
Validation: all 492 tests passed locally, including first-run Zwift-only sync and the scheduler offer. Ruff, documentation links and anchors, and issue-form YAML checks passed. Both the wheel and source distribution built successfully. Required CI covers the supported OS/Python matrix before merge.