Repository navigation
release: bump version to 2.7.0 - #108
Merged
Merged
Conversation
Svtter
commented
Nov 19, 2026
Svtter
left a comment
Contributor
Author
There was a problem hiding this comment.
自动代码评审 (review-server-neo)
✅ CAN MERGE
评审详情
纯发布 bump(VERSION 2.6.0→2.7.0 + CHANGELOG 的 [Unreleased] 收敛为 [2.7.0] - 2026-11-19),没有代码/测试改动。已核对 changelog 里新增条目的代码依据,全部成立。
Should-fix
CHANGELOG.md:7— "requires go ≥ 1.23" 与本仓库自身的 Go 要求不符:go.mod:3是go 1.24.1,README.md:3/README.cn.md:3徽章和README.md:24都写 Go 1.24+。读者会误以为 Go 1.23 可构建本项目。建议改成明确区分主体,例如 "the go-sdk requires go ≥ 1.23; this project still requires go 1.24+"。
Nits
CHANGELOG.md:3— 去掉## [Unreleased]后文件顶部直接是 2.7.0(2.6.0 发布时同样如此,属既有惯例)。若想保留 Keep a Changelog 结构,可在顶部补回空的## [Unreleased]。VERSION:1— VERSION 文件不被任何构建/发布流程读取:.goreleaser.yaml:21用{{.Version}}(git tag),Dockerfile:24用ARG VERSION,.github/workflows/release.yml:30的v2.6.1是 goreleaser-action 版本而非项目版本(全仓 grepVERSION只命中 Docker/CI 的 ARG 与 env,无文件读取)。因此打 tag 必须是v2.7.0与 VERSION 一致,否则两处会漂移。既有问题,非本 diff 引入。
已核对通过(一次性确认,无需再查)
- tool 数量与名称:
internal/cli/mcp.go:245-305共 16 个mcp.AddTool注册,与 CHANGELOG 列出的 16 个名称完全对应;4 个 admin-gated 与internal/cli/mcp.go:35注释一致(user_add/user_issue_key/user_revoke_key/audit)。 - CHANGELOG 提到的支撑能力都存在:
GET /api/me(internal/server/server.go:1409)、sth user promote|demote(internal/cli/user.go:38-40)、role 迁移(internal/session/migrate_role_test.go)、go-sdkv1.0.0(go.mod)。 - CHANGELOG 全文没有链接引用定义(grep
Unreleased无命中,文末也无[x.y.z]:引用块),所以本次改名不会留下悬空链接。
NOT VERIFIABLE(工具限制)
- 2026-11-19 是否就是实际发布日期、
v2.7.0tag 是否已按此 VERSION 打、以及 2.6.0 以来是否仍有未写入 CHANGELOG 的改动 —— 无 git/执行能力,无法核实。 - 无需新增测试:本次只是元数据/文档变更。
由 review-server-neo 自动生成。新 push 会重新评审。
…ked-issue check failure)
Svtter
commented
Nov 19, 2026
Svtter
left a comment
Contributor
Author
There was a problem hiding this comment.
自动代码评审 (review-server-neo)
✅ CAN MERGE
评审详情
结论未变。新增提交 728fc65 chore: re-trigger review 只重新触发流程,diff 与上一轮完全一致(CHANGELOG.md +1/-1、VERSION +1/-1),没有任何先前 finding 被修复或引入新问题。
仍存在的问题(与上轮相同)
- Should-fix
CHANGELOG.md:7— "requires go ≥ 1.23" 与本项目实际要求冲突:go.mod:3仍是go 1.24.1,README.md:3/README.cn.md:3徽章与README.md:24均写 Go 1.24+。读者会误判为 Go 1.23 可构建。建议改成区分写法:"the go-sdk requires go ≥ 1.23; this project still requires go 1.24+"。 - Nit
CHANGELOG.md:3— 去掉## [Unreleased]后文件顶部直接是 2.7.0(与 2.6.0 发布惯例一致,可不改)。 - Nit
VERSION:1— VERSION 文件不被任何构建/发布流程读取(.goreleaser.yaml:21用 git tag{{.Version}},Dockerfile:24用ARG VERSION;.github/workflows/release.yml:30的v2.6.1是 goreleaser-action 版本)。打 tag 必须正好是v2.7.0,否则 VERSION 与制品版本漂移。既有问题,非本 diff 引入。
代码依据复核(未变化,均通过)
internal/cli/mcp.go:245-30516 个mcp.AddTool与 CHANGELOG 列出的 16 个 tool 一一对应;4 个 admin-gated 与internal/cli/mcp.go:35注释一致。GET /api/me(internal/server/server.go:1409)、sth user promote|demote(internal/cli/user.go:38-40)、role 迁移测试(internal/session/migrate_role_test.go)、go-sdkv1.0.0(go.mod:9)均存在,changelog 描述有代码支撑。- CHANGELOG 无链接引用定义,改名不会留下悬空链接;纯元数据变更,无需新增测试。
NOT VERIFIABLE(工具限制):2026-11-19 是否为实际发布日期、v2.7.0 tag 是否已按 VERSION 打、2.6.0 以来是否仍有未记录的改动 —— 无 git/执行能力。
ship as-is
由 review-server-neo 自动生成。新 push 会重新评审。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP server 支持(#101,#103/#104/#105)+ admin 身份化授权。合并后在 main 打 v2.7.0 tag 触发 goreleaser。