Repository navigation
ci: 发版候选的安卓构建也预取 Gradle 发行包并延长依赖下载的重试 - #245
Merged
Merged
Conversation
0.3.1 的发版候选(run 42733161564,job 129556020370)在安卓腿上失败:从 dl.google.com 读 androidx.window 的 POM 超时,Gradle 按默认的三次尝试后停用了 这个仓库。#241 只给 ci.yml 的 android job 加了 prepare-gradle.sh(钉住摘要的 Gradle 发行包、每个仓库试八次),发版候选的安卓腿没有。 release-candidate.yml 的 bundle-android 在 pnpm install 之后、构建之前,经 .release-tooling 运行同一个脚本。test_release_workflows.py 检查两处都在构建前运行它。
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #245 +/- ##
==========================================
- Coverage 93.56% 93.56% -0.01%
==========================================
Files 489 489
Lines 85860 85860
Branches 4909 4909
==========================================
- Hits 80332 80331 -1
- Misses 4859 4860 +1
Partials 669 669
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
0.3.1 的发版候选(run 42733161564,job 129556020370)在安卓腿上失败:从
dl.google.com读androidx.window:window-core:1.5.1的 POM 超时,Gradle 按默认的三次尝试后停用了 Google 仓库,构建失败;重跑一次后通过。#241 只给
ci.yml的androidjob 加了.github/scripts/prepare-gradle.sh(钉住 SHA-256 的 Gradle 发行包、每个仓库试八次、间隔从 2 s 翻倍),release-candidate.yml的bundle-android没有。release-candidate.yml的bundle-android在pnpm install之后、构建之前,经.release-tooling运行同一个脚本(受信的工具检出已包含/.github/scripts/)。scripts/release/test_release_workflows.py:新增GradleDownloads,检查ci.yml与release-candidate.yml都在pnpm install之后、scripts/build-android-rn.sh --unsigned之前运行这个脚本。改之前它在release-candidate.yml上失败,改之后通过。只改发版工作流和它的测试,不改产品代码,不发版(
ci:)。Verification
python3 -m unittest discover -s scripts/release -p "test_release_workflows.py":39 个测试通过;新测试改之前失败('run: .release-tooling/.github/scripts/prepare-gradle.sh apps/mobile-rn' not found)test_fetch_pinned.py通过,actionlint .github/workflows/release-candidate.yml通过prepare-gradle:一行(要等下一次发版).github/scripts/check-no-production-hosts.sh)Risk and rollback
只影响发版候选的安卓腿:多一步下载 Gradle 发行包(经
fetch-pinned.sh核对摘要)并写GRADLE_USER_HOME/gradle.properties的两项重试设置,构建产物不变。回退就是还原这个提交。