Skip to content

sio/jsonio: return empty record for empty projection #7481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nwt merged 1 commit into from
Oct 15, 2026
Merged

sio/jsonio: return empty record for empty projection #7481

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions sio/jsonio/reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ type Reader struct {
sctx *super.Context
ctx context.Context
stream *stream
projection field.List
projection field.Projection

hasClosed atomic.Bool
}
Expand All @@ -32,15 +32,15 @@ func NewReader(ctx context.Context, sctx *super.Context, r io.Reader, p vio.Push
if inputCap == 0 {
inputCap = defaultInputCap
}
var fields field.List
var proj field.Projection
if p != nil {
fields = p.Projection().Paths()
proj = p.Projection()
}
return &Reader{
sctx: sctx,
ctx: ctx,
stream: newStream(ctx, r, concurrentReaders, inputCap),
projection: fields,
projection: proj,
}
}

Expand Down Expand Up @@ -82,7 +82,7 @@ func preorderErr(idx uint32, start int, table *vector.BytesTable, err error) err

func (r *Reader) newBuilder() jsonvec.Builder {
if r.projection != nil {
return jsonvec.NewProjectionBuilder(r.projection)
return jsonvec.NewProjectionBuilder(r.projection.Paths())
}
return jsonvec.NewBuilder()
}
Expand Down
Loading