Repository navigation
fix(appconfig): prevent panic when YAML config has non-string map keys (fixes #5258) - #5304
Open
siddiqueirshad wants to merge 1 commit into
Open
siddiqueirshad wants to merge 1 commit into
siddiqueirshad wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5258.
When loading an application configuration from YAML (such as via
fly config validate -c fly.yamlorfly deploy),stringifyYAMLMapKeyspreviously performed a direct type-assertion (k.(string)) when convertingmap[any]anykeys to string. If a YAML configuration contains non-string keys (e.g. integer or boolean keys in anenv:section like1: oneortrue: yes), this causedflyctlto crash with:Changes
internal/appconfig/serde.go: Usefmt.Sprint(k)instead ofk.(string)when buildingnewmapfrommap[any]anyso that all YAML keys are consistently stringified without panic.internal/appconfig/serde_test.go: AddedTestLoadYAMLAppConfigWithNonStringKeysto verify that YAML configurations with non-string map keys load cleanly without panic and parse into both*Configandmap[string]any.