Skip to content

Validate Tigris bucket names before creation - #5309

Open
yuri-rod wants to merge 2 commits into
superfly:masterfrom
yuri-rod:fix/tigris-bucket-name-validation
Open

yuri-rod wants to merge 2 commits into
superfly:masterfrom
yuri-rod:fix/tigris-bucket-name-validation

Conversation

@yuri-rod

@yuri-rod yuri-rod commented Oct 18, 2026 •

Copy link
Copy Markdown

Change Summary

When a Tigris bucket name is invalid, the creation API returns "The specified bucket is not valid." This change checks the selected name before creation and explains which naming rule failed, with a link to the Tigris documentation.

Validation runs after name selection, so it covers the --name flag, names derived from app names, and launch overrides. Blank names still request an automatically generated name.

The tests cover 28 cases, including invalid names, valid length boundaries, override precedence, generated names, and names used by other providers.

Checks passed:

  • make test
  • Focused race test for bucket-name validation
  • Build with Go 1.26.3
  • golangci-lint v2.11.3 with Go 1.26.3

Fixes #4728.


Documentation

  • Fresh Produce
  • In superfly/docs, or asked for help from docs team
  • n/a

Copilot AI balanced review requested due to automatic review settings October 18, 2026 05:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@yuri-rod yuri-rod left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error message for bucket creation is ambiguous

3 participants