fix: validate unsupported template placeholders - #249
Open
RoopakBRK wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe template text extraction path now reports unsupported placeholders with a descriptive ChangesTemplate error handling
Merge Risk: ⚪ Minimal · up to This change converts unsupported template placeholders into clearer validation errors. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a small validation improvement for query and document templates.
Issue - When an unsupported placeholder is used in a template, for example {domain}, Python currently raises a KeyError when formatting the template. This doesn't make it very clear to the user that the problem is with the template they provided.
What did I change ?
I added handling for the KeyError raised by template.format() and converted it into a ValueError with a more helpful message that points out which placeholder is not supported.
Testing
I ran the targeted tests for extract_texts, and all 9 tests passed. I also ran:
mise run test
mise run lint
mise run typecheck
git diff --check
File Changed -> sie/packages/sie_server/src/sie_server/adapters/_utils.py
Summary by CodeRabbit