Accept a case-insensitive Bearer prefix on the config API - #250
Open
gyanu2507 wants to merge 1 commit into
Open
Conversation
The gateway already treats `bearer token` as valid. The Python config service only stripped a capital Bearer prefix, so the same header 401ed.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughChangesAuthorization token parsing
Merge Risk: ⚪ Minimal · up to The configuration API now accepts case-insensitive, whitespace-tolerant Bearer authorization prefixes while retaining raw-token and invalid-token behavior. No current merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gateway already accepts
bearer <token>(RFC 7235). The Python config service only stripped a capitalBearerprefix, so the same header that works on inference returned 401/403 on/v1/configs.One helper now trims, strips a case-insensitive Bearer prefix, and still accepts a raw token with no scheme.
Test plan
Authorization: bearer <admin>reaches/v1/configs/exportBEARERwith extra spaces also worksSummary by CodeRabbit
Bug Fixes
Tests