Skip to content

Expose wrapper notification workflow on default branch - #477

Merged
ianrumac merged 1 commit into
mainfrom
codex/enable-manual-wrapper-notify
Oct 9, 2026
Merged

ianrumac merged 1 commit into
mainfrom
codex/enable-manual-wrapper-notify

Conversation

@ianrumac

@ianrumac ianrumac commented Oct 9, 2026

Copy link
Copy Markdown
Collaborator

Changes in this pull request

Checklist

  • All unit tests pass.
  • All UI tests pass.
  • Demo project builds and runs.
  • I added/updated tests or detailed why my change isn't tested.
  • I added an entry to the CHANGELOG.md for any breaking changes, enhancements, or bug fixes.
  • I have run ktlint in the main directory and fixed any issues.
  • I have updated the SDK documentation as well as the online docs.
  • I have reviewed the contributing guide

@ianrumac
ianrumac changed the base branch from develop to main October 9, 2026 13:22

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

This PR targets main, but the repo's default branch is develop. As things stand it conflicts with main, and even if it merged it would not expose Run workflow.

Reviewed changes

I reviewed the one commit, which adds notify-wrappers.yml so the manual dispatch button shows up.

  • notify-wrappers.yml on a new branch — the file is the same as origin/main's copy apart from a new two-line header saying it must live on the default branch.

⚠️ The PR base is main, but the default branch is develop

GitHub only shows the workflow_dispatch Run workflow button for workflow files that exist on the default branch, and here that is develop. The branch was cut from develop at 86881e9, which is an ancestor of main. main already has notify-wrappers.yml from 575662e and 2a9cc37, so this PR is an add/add conflict there (mergeable: CONFLICTING). It also would not change anything about the button's visibility.

Technical details
# PR targets the wrong base branch

## Affected sites
- PR #477 base ref — `main` (should be `develop`, per `defaultBranchRef`)
- `.github/workflows/notify-wrappers.yml` — already exists on `origin/main` with different header lines → add/add conflict

## Required outcome
- The workflow file lands on `develop` so the Actions UI exposes **Run workflow**.

## Suggested approach
- Retarget the PR base to `develop`. The branch is already based on `develop`'s tip, so the diff stays this one file and should merge cleanly.

## Open questions for the human
- Would it be better to merge `main` back into `develop` (or cherry-pick `575662e` and `2a9cc37`) instead of re-adding the file by hand? That keeps both branches identical. It also brings the `uses: ./.github/workflows/notify-wrappers.yml` job from `main`'s `build+test+deploy.yml` (around line 189) into `develop`, and it avoids a second add/add conflict on this file the next time `develop` merges into `main`, since the two copies differ in their header comment.

Pullfrog  | Fix it ➔ | View workflow run | Using claude-opus-5.5 | 𝕏

@ianrumac
ianrumac force-pushed the codex/enable-manual-wrapper-notify branch from a7969eb to 2e2558e Compare October 9, 2026 13:26
@ianrumac
ianrumac merged commit fc5cbec into main Oct 9, 2026
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant