Skip to content

Notify the Unity package when Android releases - #478

Open
ianrumac wants to merge 1 commit into
mainfrom
chore/notify-unity-wrapper
Open

ianrumac wants to merge 1 commit into
mainfrom
chore/notify-unity-wrapper

Conversation

@ianrumac

@ianrumac ianrumac commented Oct 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Adds superwall/Superwall-Unity to the wrapper dispatch list, so an Android release tells Unity to open a bump PR the way Flutter, Expo, and KMP already are.
  • Depends on Open a PR when a native SDK releases Superwall-Unity#12 landing native-sdk-bump.yml on main. Until then a dispatch to Unity fails, and the other wrappers are still notified.

Test plan

  • Confirm WRAPPER_DISPATCH_TOKEN has Contents read & write on superwall/Superwall-Unity. The dispatch API checks that permission, and a token that cannot see the repo fails this job.
  • After the Unity workflow is on main, run this workflow by hand for a version Unity does not already pin and confirm the Unity bump workflow starts.

Unity now opens a bump PR from native-sdk-release, and it was missing from the dispatch list.

Co-authored-by: Cursor <cursoragent@cursor.com>

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

I reviewed the one-commit change that adds Unity to the list of wrappers notified on an Android release.

  • Unity added to WRAPPER_REPOS: notify-wrappers.yml now sends native-sdk-release to superwall/Superwall-Unity along with Flutter, Expo and KMP, through the same per-repo loop. One repo failing does not stop the others.
  • Comment updates: the header in notify-wrappers.yml and the notify_wrappers job comment in build+test+deploy.yml now list Unity.

ℹ️ Until Superwall-Unity#12 lands, the Unity dispatch is silently ignored rather than failing

The description says a dispatch to Unity fails until native-sdk-bump.yml is on Unity's main. That is not quite right. POST /repos/{owner}/{repo}/dispatches returns 204 whether or not any workflow listens for the event, so the job stays green and nothing happens on the Unity side. This means the two PRs can merge in either order. The only thing that would turn this job red is WRAPPER_DISPATCH_TOKEN lacking access to Superwall-Unity (a 404 from gh api), which the test plan already covers. Note that a version released before #12 lands will not start a Unity bump on its own. You would re-send it with notify_wrappers_only.

Pullfrog  | View workflow run | Using claude-opus-5.5 | 𝕏

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant