Repository navigation
fix(mail): OR the values of one mail list --from/--to flag - #8
Merged
Merged
Conversation
Several --from or --to values, repeated or comma-separated, were joined into the KQL with AND, which matches nothing. Each flag's values now form one group, (from:a OR from:b); a single value stays from:a. --search, the groups and the received date terms are still joined with AND, and --search is parenthesised when other terms join it, so an OR in it stays inside it. A bare domain such as @example.com passes through as from:@example.com.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mail list --fromand--tonow match any of their values. Several values, repeated or comma-separated, become one KQL OR group,(from:a OR from:b); a single value staysfrom:a. Before this change they were ANDed and matched nothing.--search, the--fromgroup, the--togroup and the received dates are still joined with AND.--searchis parenthesised when other terms join it, so an OR inside it stays inside it.@example.compasses through asfrom:@example.comand matches every address at it.reference/commands/mail.md) and CHANGELOG[Unreleased]updated.Tests: 905 passed locally. Live read-only check on a real tenant:
--from @domain42,--from <external>8,--from @domain,<external>50.