fix(items): block trading, storing and selling the Wizard's Ring - #643
Merged
Merged
Conversation
OpenMU binds the Wizard's Ring to the character: it can't be traded, moved to the vault or a personal store, or sold to an NPC while it has durability left. The client allowed all of that at +0, so the server refused requests the client sent. The ring's data now blocks trading, storing, selling to NPCs and selling in a personal store; dropping stays allowed, as on the server. The server still allows selling a ring with zero durability; the item data can't express that, so the client doesn't offer it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the client item data with OpenMU (MUnique/OpenMU#983, the server part of data-driven items phase 3).
OpenMU binds the Wizard's Ring (13,20) to the character (
IsBoundToCharacter), so the server refuses to trade it, to move it to the vault or a personal store, and to sell it to an NPC while it has durability left. The client allowed all of that at +0, so it sent requests the server refused, and with #983 the server logs them as a client data mismatch.Changes
Group13_Helper.json: the Wizards Ring getstradable,storable,sellableandpersonalShopSellableset tofalse.repairable: falsewas already set. Dropping stays allowed, as on the server, where only the owner can pick it up again.test_item_rules.cpp: expects it blocked for trade, vault, personal store and NPC sale at +0, +1 and +2, and droppable.docs/item-data.md: notes that the ring's flags already block everything at every level.The level exceptions for the ring in the rule code stay. They are redundant now, but still describe the level variants, which a later phase turns into items of their own.
One difference remains: the server still allows selling a ring with zero durability. The item data can't express that, so the client doesn't offer the sale.
Tests
Windows editor build (Release):
test_item_database(39) andtest_item_database_files(20) pass. The latter includes the check that the shipped item files match the writer's output exactly.