Repository navigation
docs: set the mark's ground one step down from the page - #186
Merged
Merged
Conversation
- move the card from `--light-paper` to `--light-surface-2`, which is what the skin puts behind a thumbnail - on paper the tile dissolved into the page and only the building read; a step down makes it a tile, and stopping short of white keeps it from glaring on a dark GitHub theme - regenerate the social card, whose mark had gone out of step with the file it is drawn from - amend ADR-0005, which still named the colour it no longer uses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The mark shipped on
--light-paper#fbfbfa, which is the page its frame sitson, so the tile dissolved and only the building read. This moves it to
--light-surface-2#f2f2f0— what the skin already puts behind a thumbnail.docs/assets/mark.png— reground to#f2f2f0docs/assets/social1280.png— regenerated; its mark had gone out of step withthe file it is drawn from
Stopping short of white also helps on a dark GitHub theme, where the near-white
tile glared. That is as far as a single-image mark can meet a dark theme.
Validation
node scripts/check.mjs— 25 checks, passed.Both grounds were read back from the files rather than assumed: a strip across
the mark's margin is one value,
#f2f2f0, and the card the generator draws is#fbfbfawith that tile on it. Worth stating because the first attempt at thegrey left 4% of the old white in every pixel of a field that is meant to be
flat — three values where there should be one — and it is invisible.