Repository navigation
docs: lighten the tile behind the mark, and put the card on surface - #194
Merged
Merged
Conversation
- the tile moves from `--light-surface-2` to `#f7f7f6`, which read as a grey slab against a white page at the darker value - the social card moves from `--light-paper` to `--light-surface`: a card is not a page, and the skin's own cards are surface - that correction is also what makes room for the lighter tile — against paper it separates by 1.035, against surface by 1.072, where the arrangement it replaces managed 1.083 - record in ADR-0005 that the tile is the one value here that is not a token, and what was tried on either side of it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tile behind the mark read as a grey slab against a white page. It moves from
--light-surface-2#f2f2f0to#f7f7f6.Lightening it alone would have broken the social card: the card was
--light-paper#fbfbfa, and a#f7f7f6tile separates from that by 1.035 —close enough to stop being a tile at all.
So the card moves too, to
--light-surface#ffffff. That is the more correcttoken regardless: a card is not a page, and every card in the skin is
--light-surface.#f2f2f0#fbfbfa#f7f7f6#fbfbfa#f7f7f6#ffffffOn the value
#f7f7f6is the only number in this decision that is not a token, and ADR-0005now says so and says what was tried on either side.
--light-paperdissolvedinto the page;
--light-surface-2was a slab. There is no token between them.Validation
node scripts/check.mjs— 26 checks, passed, including the palette checkagainst the generator's new
--light-surfacedeclaration.Read back out of the generated files: the mark's margin is one value,
#f7f7f6;the card is
#ffffff. Margins are unchanged at 183/183 horizontally and 134/134vertically.