Repository navigation
docs: keep the card the mark is cut from, and hand the shape upstream - #197
Merged
Merged
Conversation
- add `mark-source.png`, the card `mark.png` is built from, so the mark can be rebuilt here rather than from a folder that is in no repository and moved once while it was being read from - add a note beside the assets saying what each file is and which of them is generated from which - ADR-0005 recorded the shape because this is where it was decided, not where it applies. the next repository to want a mark did not find it and built one at 180x220 with no tile. the rule and a generator now live in the organisation defaults, and what stays here is why this project chose its colour - verification: 27 checks pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the source card
mark.pngis built from, a short note beside the assets,and points ADR-0005's shape rule at the organisation copy that now owns it.
Why
The mark's shape was written down in this repository's decision record, because
this is where it was decided. It is not where it applies:
swarea/mori-lenswanted a mark, did not find the rule, and shipped one at 180×220 with no tile,
displayed in a 96×96 box.
That rule and a generator now live at
swarea/.githubdocs/repository-mark.md.ADR-0005 keeps the part that is genuinely this project's — why blue, when the
organisation is also blue — and hands the shape upstream.
mark-source.pngis here for a plainer reason. The card set is in no repositoryand moved during the session it was being read from. Without the card, this
repository can display its mark and cannot remake it — at another size, or if the
ground changes again, which it has three times.
How it was verified
npm run check— 27 checks pass, includingpreview palette (2 generators),which is back to two: the generator drafted here has moved to the organisation
repository, where it is not coupled to this project's tokens.
mark-source.pngopens as 1254×1254 RGB, the card as the set ships it.mark.pngis 512×512, ground#f7f7f6,and its alpha channel is identical pixel for pixel to the mark rebuilt for
mori-lensunder the same formula.Cost
216 KB for the source card. It buys the ability to regenerate a shipped file from
its input.
Not here
The other 111 cards in the set. Four are in use across the organisation and the
rest are candidates nobody chose — a library with no diff worth reading, which is
a backup problem rather than a version control one.