Skip to content

Soundness: add additional tool arguments input to API breakage check #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FranzBusch merged 1 commit into from
Oct 20, 2026
Merged

Soundness: add additional tool arguments input to API breakage check #324

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/soundness.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ on:
type: string
description: "Container image for the API breakage check job. Defaults to latest Swift Ubuntu image."
default: "swift:6.3-noble"
api_breakage_check_additional_arguments:
type: string
description: "Additional arguments to pass directory to the `swift package diagnose-api-breaking-changes` invocation."
default: ""
docs_check_enabled:
type: boolean
description: "Boolean to enable the docs check job. Defaults to true."
Expand Down Expand Up @@ -155,6 +159,7 @@ jobs:
env:
API_BREAKAGE_CHECK_BASELINE: ${{ inputs.api_breakage_check_baseline }}
API_BREAKAGE_CHECK_ALLOWLIST_PATH: ${{ inputs.api_breakage_check_allowlist_path }}
API_BREAKAGE_CHECK_ADDITIONAL_ARGUMENTS: ${{ inputs.api_breakage_check_additional_arguments }}
# zizmor: ignore[template-injection]
run: |
${{ inputs.linux_pre_build_command }}
Expand All @@ -166,9 +171,9 @@ jobs:
fi
echo "Using baseline: $BASELINE_REF"
if [[ -z "${API_BREAKAGE_CHECK_ALLOWLIST_PATH}" ]]; then
swift package diagnose-api-breaking-changes "$BASELINE_REF"
swift package diagnose-api-breaking-changes "$BASELINE_REF" ${API_BREAKAGE_CHECK_ADDITIONAL_ARGUMENTS}
else
swift package diagnose-api-breaking-changes "$BASELINE_REF" --breakage-allowlist-path "${API_BREAKAGE_CHECK_ALLOWLIST_PATH}"
swift package diagnose-api-breaking-changes "$BASELINE_REF" --breakage-allowlist-path "${API_BREAKAGE_CHECK_ALLOWLIST_PATH}" ${API_BREAKAGE_CHECK_ADDITIONAL_ARGUMENTS}
fi

docs-check:
Expand Down
Loading