Skip to content

Only read the PE header when verifying downloaded Windows installers #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FranzBusch merged 1 commit into from
Oct 26, 2026
Merged

Only read the PE header when verifying downloaded Windows installers #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/scripts/windows/install-vsb.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,16 @@ function Invoke-WebRequestWithRetry {
}

# Verify file is not corrupted by checking if it's a valid PE executable
$fileBytes = [System.IO.File]::ReadAllBytes($OutFile)
if ($fileBytes.Length -lt 2 -or $fileBytes[0] -ne 0x4D -or $fileBytes[1] -ne 0x5A) {
# Read only the header; ReadAllBytes throws on files over 2 GB
$fileBytes = New-Object byte[] 2
$stream = [System.IO.File]::OpenRead($OutFile)
try {
$bytesRead = $stream.Read($fileBytes, 0, 2)
}
finally {
$stream.Dispose()
}
if ($bytesRead -lt 2 -or $fileBytes[0] -ne 0x4D -or $fileBytes[1] -ne 0x5A) {
throw "Downloaded file is not a valid executable (missing MZ header)"
}

Expand Down
12 changes: 10 additions & 2 deletions .github/workflows/scripts/windows/swift/install-swift.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,16 @@ function Invoke-WebRequestWithRetry {
}

# Verify file is not corrupted by checking if it's a valid PE executable
$fileBytes = [System.IO.File]::ReadAllBytes($OutFile)
if ($fileBytes.Length -lt 2 -or $fileBytes[0] -ne 0x4D -or $fileBytes[1] -ne 0x5A) {
# Read only the header; ReadAllBytes throws on files over 2 GB
$fileBytes = New-Object byte[] 2
$stream = [System.IO.File]::OpenRead($OutFile)
try {
$bytesRead = $stream.Read($fileBytes, 0, 2)
}
finally {
$stream.Dispose()
}
if ($bytesRead -lt 2 -or $fileBytes[0] -ne 0x4D -or $fileBytes[1] -ne 0x5A) {
throw "Downloaded file is not a valid executable (missing MZ header)"
}

Expand Down
Loading