Repository navigation
Add a macOS pool label only when one is given - #341
Merged
Merged
Conversation
`macos_runner_pool` defaulted to `general`, so every macOS job asked for a runner carrying that label. The macOS runners of the `swiftlang` organization have no pool labels, so their jobs waited for a runner that did not exist, where `swift_package_test.yml` asked for `self-hosted`, `macos`, the OS and the architecture alone. The pool defaults to empty and adds no label. A repository whose runners are split into pools, such as the `apple/swift-nio` ones, names it, as the swift-nio family of adopters already does.
FranzBusch
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macos_runner_pooldefaulted togeneral, so every macOS job asked for a runner carrying that label. The macOS runners of theswiftlangorganization have no pool labels, so their jobs waited for a runner that did not exist, whereswift_package_test.ymlasked forself-hosted,macos, the OS and the architecture alone.The pool defaults to empty and adds no label. A repository whose runners are split into pools, such as the
apple/swift-nioones, names it, as the swift-nio family of adopters already does.