Repository navigation
JNI: expose C-compatible types and calls to C++ consumers - #25
Open
NakaokaRei wants to merge 1 commit into
Open
NakaokaRei wants to merge 1 commit into
NakaokaRei wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
C++-enabled Swift consumers import different JNI types from Android's
jni.hthan a runtime compiled in C mode. Accessing imported function-table fields or constructing an object-valuedjvaluein the consumer can also expose those C++ types, causing type mismatches.This extracts the low-level helpers from swiftlang/swift-java#927 into JNI Core, following the review feedback.
Solution
JNITypesaliases and an object-value factory defined in the runtime's C import context.JNIEnvironment.swiftInterfaceso consumers preserve those signatures without casts.String.concat, passing an object argument throughjvalueand converting the returned reference.Testing
Integration checks used a local dependency override. The companion changes in swift-java will consume these helpers after they are available upstream.