Repository navigation
Conversation
Author
|
The CS error is unrelated to the change. |
stof
reviewed
Sep 24, 2026
mickverm
force-pushed
the
php-8.6-deprecation
branch
from
September 24, 2026 14:39
a78a184 to
80b4039
Compare
mickverm
commented
Sep 25, 2026
| return ''; | ||
| } | ||
|
|
||
| if (!$isRequire || !isset($config['extra']['symfony']['require'])) { |
Author
There was a problem hiding this comment.
The if(!$isRequire) could even be moved before the try.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 8.6 deprecates returning from a
finallyblock.The current implementation returns from
finally. When an exception is thrown in thetryblock,$configremains undefined, causing!isset($config['extra']['symfony']['require'])to evaluate totrue. As a result, thefinallyblock returns''and the original exception is swallowed.To preserve this existing behaviour while removing the deprecated
returnfromfinally, the exception is explicitly caught and''is returned from thecatchblock instead.No functional change is intended.