4th overload (name, ...children) is not working as expected

Initial checklist

I read the support docs
I read the contributing guide
I agree to follow the code of conduct
I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Affected package

xastscript

Steps to reproduce

Hi!

This overload:

xastscript/lib/index.js

Line 57 in c1b6eca

* (name: string, ...children: Array<Child>): Element

is not working as expected

import { x } from "xastscript";

const ast = x("foo", x("bar", "baz"));

console.log(JSON.stringify(ast, null, 2));

Actual behavior

{
  "type": "element",
  "name": "foo",
  "attributes": {
    "type": "element",
    "name": "bar",
    "attributes": "[object Object]",
    "children": "[object Object]"
  },
  "children": []
}

Expected behavior

{
  "type": "element",
  "name": "foo",
  "attributes": {},
  "children": [
    {
      "type": "element",
      "name": "bar",
      "attributes": {},
      "children": [
        {
          "type": "text",
          "value": "baz"
        }
      ]
    }
  ]
}

Runtime

No response

Package manager

No response

Operating system

No response

Build and bundle tools

No response

It's matched as attributes which is expected.

See also

xastscript/lib/index.js

Lines 150 to 161 in c1b6eca

    
           function isAttributes(value) { 
        
             if ( 
        
               value === null || 
        
               value === undefined || 
        
               typeof value !== 'object' || 
        
               Array.isArray(value) 
        
             ) { 
        
               return false 
        
             } 
        
             return true 
        
           }

So you can try array instead.

import { x } from "xastscript";

const ast = x("foo", [x("bar", "baz")]);

console.log(JSON.stringify(ast, null, 2));

@JounQin

@JounQin then the TS type needs to be updated if this is not supported

From (name: string, ...children: Array<Child>): Element to (name: string, children: Array<Child>): Element maybe?

@GauBen

@GauBen No, it's just (name: string, attributes?: Attributes, ...children: Array<Child>): Element been matched.

x("bar", "baz") matches Attributes, it's hard to distinguish a single Child vs Attributes at runtime.

The runtime code matches (name: string, attributes?: Attributes, ...children: Array<Child>): Element but the TS type matches x(name: string, ...children: Array<Child>): Element:

ts playground

Navigation Menu

Repository navigation

4th overload `(name, ...children)` is not working as expected #16

Initial checklist

Affected package

Steps to reproduce

Actual behavior

Expected behavior

Runtime

Package manager

Operating system

Build and bundle tools

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function isAttributes(value) {
	if (
	value === null \|\|
	value === undefined \|\|
	typeof value !== 'object' \|\|
	Array.isArray(value)
	) {
	return false
	}

	return true
	}

4th overload (name, ...children) is not working as expected #16

Description

Initial checklist

Affected package

Steps to reproduce

Actual behavior

Expected behavior

Runtime

Package manager

Operating system

Build and bundle tools

Activity

JounQin commented on Oct 10, 2026

github-actions commented on Oct 10, 2026

GauBen commented on Oct 10, 2026

JounQin commented on Oct 10, 2026

GauBen commented on Oct 10, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions

4th overload `(name, ...children)` is not working as expected #16