Skip to content

chore: drop macOS from CI (hosted larger-runner quota) #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanleecode merged 1 commit into from
Oct 7, 2026
Merged

chore: drop macOS from CI (hosted larger-runner quota) #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/workflows/platform.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,6 @@ jobs:
suffix: linux-arm64
runner: ubuntu-24.04-arm
bin: comment-checker
- target: x86_64-apple-darwin
suffix: darwin-x64
runner: macos-14
bin: comment-checker
- target: aarch64-apple-darwin
suffix: darwin-arm64
runner: macos-14
bin: comment-checker
- target: x86_64-pc-windows-msvc
suffix: win32-x64
runner: windows-2022
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tools.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-14, windows-2022]
os: [ubuntu-latest, windows-2022]
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
with:
Expand Down
16 changes: 0 additions & 16 deletions release.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,22 +45,6 @@
"runner": "ubuntu-24.04-arm",
"bin": "comment-checker",
},
{
"target": "x86_64-apple-darwin",
"suffix": "darwin-x64",
"os": "darwin",
"cpu": "x64",
"runner": "macos-14",
"bin": "comment-checker",
},
{
"target": "aarch64-apple-darwin",
"suffix": "darwin-arm64",
"os": "darwin",
"cpu": "arm64",
"runner": "macos-14",
"bin": "comment-checker",
},
{
"target": "x86_64-pc-windows-msvc",
"suffix": "win32-x64",
Expand Down
16 changes: 0 additions & 16 deletions scripts/lib/targets.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,22 +17,6 @@
"runner": "ubuntu-24.04-arm",
"bin": "comment-checker"
},
{
"target": "x86_64-apple-darwin",
"suffix": "darwin-x64",
"os": "darwin",
"cpu": "x64",
"runner": "macos-14",
"bin": "comment-checker"
},
{
"target": "aarch64-apple-darwin",
"suffix": "darwin-arm64",
"os": "darwin",
"cpu": "arm64",
"runner": "macos-14",
"bin": "comment-checker"
},
{
"target": "x86_64-pc-windows-msvc",
"suffix": "win32-x64",
Expand Down
4 changes: 2 additions & 2 deletions scripts/tools/check-matrix.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ import {

// The product platform set: a known list the table must name, not a copy
// derived from the table under check.
const EXPECTED_SUFFIXES = ['linux-x64', 'linux-arm64', 'darwin-x64', 'darwin-arm64', 'win32-x64']
const EXPECTED_SUFFIXES = ['linux-x64', 'linux-arm64', 'win32-x64']

// Known-good hosted runners. The release workflow's per-row runner must match
// the table's canonical runner AND be one of these — a retired or mistyped
// label (e.g. macos-13) must fail the gate, not pass it (issue #8 refit).
const KNOWN_RUNNERS = new Set(['ubuntu-latest', 'ubuntu-24.04-arm', 'macos-14', 'windows-2022'])
const KNOWN_RUNNERS = new Set(['ubuntu-latest', 'ubuntu-24.04-arm', 'windows-2022'])

const failures: string[] = []
const fail = (reason: string) => failures.push(reason)
Expand Down
Loading