Repository navigation
chore: drop darwin from flake and install docs - #132
Merged
Merged
Conversation
PR #131 already removed macOS from CI and release (platform.yml matrix, targets.json, release.jsonc, check-matrix gate). This removes the last darwin/macOS references: - flake.nix: drop x86_64-darwin/aarch64-darwin from the systems list, narrow meta.platforms to linux, and drop the macOS attribution from the no-sandbox HOME comment (the rationale holds on any no-sandbox nix). - README / CONCEPTS: state Linux and Windows (not macOS) as the built platforms; fix the stale 'five platform pins' to three. - check-matrix note: 'five' -> 'three' platform pins. macOS is no longer a build or distribution target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #131 removed macOS from CI and release (platform.yml matrix,
targets.json,release.jsonc, thecheck-matrixgate). This removes the last darwin/macOS references so nothing still implies a Mac build or distribution target.Changes
x86_64-darwin/aarch64-darwinfrom thesystemslist; narrowmeta.platformsfromunixtolinux; drop the macOS attribution from the no-sandboxHOMEcomment (the rationale holds on any no-sandbox nix, not just macOS). NoisDarwinbranches or darwin-only inputs/packages existed.-linux-arm64) instead of-darwin-arm64; "five" platform pins -> "three".macos-13mention in a gate comment is kept on purpose: it documents a runner the gate must reject.)nonechangeset for the publishable-package touch.Verification (local)
check-matrixgate: ok.@std/yaml); no darwin/macos remains in.github/workflows.deno fmt --checkanddeno lintpass on the editedcheck-matrix.ts.nix flake show/checkcould not run in this sandbox (no/nix/storewrite); CI covers the flake build. Flake syntax edit is a one-line list trim plus comment/meta text.Public repo: stays on GitHub-hosted Linux runners; no fleet labels. No secrets changes.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.