Repository navigation
chore: low-friction commitlint (drop cosmetic hard-fails) - #79
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apply the org-decided low-friction commitlint policy to the repo-root
commitlint.config.ts. commitlint change only.What changed
subject-full-stop,header-full-stop,body-full-stop->0(off)scope-enum->0(off); the staticSCOPESenum deletedscope-case->1(warn, was error)type-matches-diff-shapedeleted entirely, along with its plugin rule and all its machinery (stagedFiles(),ALLOWED_BY_SHAPE, theisDoc/isTest/isCI/isLockfile/isTooling/matchesAnymatchers, and thenode:child_processimport)body-leading-blank,footer-leading-blank->1(warn, was off)Kept at error (the real bars)
no-ai-coauthors,type-empty,type-case,type-enum(same 16 entries),subject-empty. Theno-ai-coauthorsplugin rule and patterns are untouched.Why
These rules fail a whole commit for cosmetic reasons (a trailing period, an unguessable scope, a heuristic type-vs-diff guess) that have zero release or correctness impact: releases run on changesets (
.changeset/*.md), not commit messages. Dropping them stops spurious whole-commit failures on agent commits while keeping the one message policy that matters (the AI-coauthor ban) and tidy log grouping (type).Verified
With the pinned toolchain (
@commitlint/cli@21.2.3,config-conventional@21.2.3):printf 'feat: add thing.' | commitlint-> exit 0 (trailing period no longer fails)type-empty)no-ai-coauthors)--print-config jsonconfirms every rule level aboveNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.