Repository navigation
chore: adopt org tsgo stack (TS7 + @systemfsoftware/tsconfig base + @effect/language-service) - #2
Merged
Merged
Conversation
…effect/language-service) Bring qmd onto the System F Software standard tsgo toolchain: - tsconfig.json extends @systemfsoftware/tsconfig/tsc/no-dom/library (Node library, no DOM, standalone — not monorepo/composite) and adds the @effect/language-service plugin; drops dead jsx/allowJs (no JSX/.js sources). - tsconfig.build.json extends the local base, sets rootDir=src for a deterministic declaration emit (TS7 TS5011). - devDeps: typescript ^7, @effect/tsgo ^0.50.0, @effect/language-service, @systemfsoftware/tsconfig ^2.0.1, oxlint-tsgolint 7.0.2001, @types/node ^24. peerDependencies.typescript -> ^7 (full upgrade, no dual compiler). - Migrated src to the stricter base: noPropertyAccessFromIndexSignature (index-signature access via brackets) and exactOptionalPropertyTypes (optional props/params widened to accept undefined). No runtime behavior change; no TS5 compiler-API usage existed to migrate. Typecheck (tsc -p tsconfig.build.json --noEmit) and oxlint both pass; dist emits declarations + sourcemaps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings qmd onto the System F Software standard tsgo toolchain.
What changed
tsconfig.jsonnow extends@systemfsoftware/tsconfig/tsc/no-dom/library(Node library, no DOM, standalone — not monorepo/composite) and adds the@effect/language-serviceplugin. Dropped the deadjsx: react-jsx/allowJs(no JSX or.jssources exist).tsconfig.build.jsonextends the local base and setsrootDir: "src"for a deterministic declaration emit (TS7 is stricter —TS5011).declaration/sourceMapnow come from the base.typescript ^7,@effect/tsgo ^0.50.0,@effect/language-service,@systemfsoftware/tsconfig ^2.0.1,oxlint-tsgolint 7.0.2001,@types/node ^24.peerDependencies.typescript→^7(full upgrade, no dual-compiler).noPropertyAccessFromIndexSignature— index-signature reads (process.env.X, parsed-arg bags) rewritten to bracket access.exactOptionalPropertyTypes— optional properties/params on the public option/result types (and a few inline signatures) widened to acceptundefined; twoRequired<…>/resolver return types made concrete.Verification (local)
tsc -p tsconfig.build.json --noEmit→ 0 errors (also 0 ontsconfig.json), under TypeScript 7.0.2.oxlint→ 0 warnings, 0 errors.node scripts/build.mjs→ cleandist/with.d.ts+ sourcemaps.commit.gpgsignwith no local key; one sandbox-filesystem test that is green onmain's CI) — none introduced by this change.Lockfiles:
bun.lockregenerated for the CI Bun job (bun install --frozen-lockfile); the stale committedpnpm-lock.yamlwas refreshed to matchpackage.json.