Repository navigation
build(release): pin pnpm-release-management to bb3b8b5 for repository changelogs and pr after bump - #233
Merged
Conversation
… changelogs and pr after bump
Contributor
There was a problem hiding this comment.
Verified: 11/11 green on 8277aef; flake.lock only; a-d evidence shows bump writes CHANGELOG sections (stryker-js 18.0.0), the guard passes, pr against a bare remote commits exactly the bump's tree with no artifacts, and the release dry-run lists 17 releases with notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This bumps
flake.lock'spnpm-release-managementinput from603ecb4tobb3b8b5. That rev includes:bumpwrites each member'sCHANGELOG.mdunderversioning.changelog.storage: repository.propens the release PR from the tree bump left, and commits only tracked changes plus the changelogs bump created.Nothing else is needed. This repo already sets
storage: repositoryinpnpm-workspace.yaml, the dev shell already carries the pinned pnpm (#232), and the reusable workflow already runs bump then pr. The diff isflake.lockonly.Evidence (throwaway
git clone --no-localof this branch, deleted afterwards)nix develop --command version-management bumpexits 0 and printsversioned packages.@systemfsoftware/stryker-jsmoves to18.0.0.CHANGELOG.mdfiles changed or appeared, one of them new:test/e2e-core/CHANGELOG.md. Each gains a## <version>section; for stryker-js that is## 18.0.0..changeset/changelogs/does not exist afterwards, so nothing is parked.pnpm guard:projectsexits 0:17 publishable package(s) each carry exactly one section for their version, and no section is parked.url.<bare>.pushInsteadOf, and a fake GitHub API viaGITHUB_API_URL(prhas no dry-run). Before runningpr, I put an untracked.release/captured.jsonand aresultsymlink in the checkout.github-release-management prexits 0 and printscreated release PR #1.GET pulls?head=changeset-release/main,POST /pulls(titlechore(release): version packages) andPOST /issues/1/labels ["release"].changeset-release/mainon the bare remote has one commit,chore(release): version packages. Its diff is 1 A, 20 D and 35 M, the same set bump produced. Zero paths match.release/orresult.git statusafterwards shows only?? .release/captured.json.github-release-management release --dry-runexits 0 and printsdry run: 17 release(s), including@systemfsoftware/stryker-js@v18.0.0. The release phase refuses withReleaseChangelogMissingorReleaseChangelogEmptywhenever a member's notes are missing or empty, so exit 0 over all 17 means every release has non-empty notes.Nothing was run with stryker.