Repository navigation
feat: start match searches through internal Players and Builds APIs - #120
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
PANiXiDA
changed the title
PANiXiDA
changed the title
PANiXiDA
changed the title
Contributor
Author
|
Codex Review: Didn't find any major issues. 🎉 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add authenticated
POST /api/v1/match-searchesacceptingbuildIdandmode, returning204 No Contenton success. Matchmaking resolves the current user's player and selected build through the Players and Builds internal APIs. Missing players, unavailable builds, and builds owned by another player return404.Each provider exposes a dependency-free Contracts API with nullable response DTOs. The implementations live in their owning
Presentation/Internalfolders and dispatch the ordinaryGetInternalPlayerandGetInternalBuildApplication queries through Mediator. Handlers, validators, and read models remain in Application; EF projection and soft-delete filtering remain behind read repositories in Infrastructure. Host registration includes each module's Presentation services.Matchmaking declares
IPlayersClientandIBuildsClientinApplication/Abstractionsand itsPlayerReadModelandBuildReadModelinApplication/ReadModels, both implementingIReadModel.IBuildsClient.GetByIdAsyncnow returns the persisted build's ID and player ID through Builds.Contracts. Application validates the returned player ID before accessing its domain value and checks build ownership. Outgoing clients are registered throughClients/DependencyInjection/AddClients().Start only creates a new search. Existing Searching or Matched entries return
409, including overdue Searching entries, without updating or replacing them.GetActiveByPlayerIdAsyncuses EF LINQ and standard soft-delete filtering. The unique active-player index prevents duplicate active searches, andxminprotects concurrent updates. Translating a racing insert's unique-index violation into409is deferred; that case can currently produce500.Functional tests use persisted Players and Builds data, including foreign and deleted builds, and verify that nested module queries preserve the outer Matchmaking command's persistence flow. Architecture tests require every public module
I*Apicontract to have one implementation in its owning Presentation assembly.Validation: