Repository navigation
Conversation
Server(name, self.description) passed the description as the second positional arg of mcp Server.__init__, which is version — so MCP clients saw the server description as its version and no instructions at all. Pass both explicitly: version from the FastAPI app version and description as instructions. Adopted from tadata-org#317 (original patch by @syf2211).
Author
|
Closing for housekeeping - the repo had no reviewer engagement and we are re-approaching these areas through a narrower pipeline. Happy to reopen on request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopted from #317 (original patch by @syf2211) — rebased onto current main and verified.
Why this is needed
setup_server() calls Server(self.name, self.description) — the second positional parameter of mcp Server.init is version, not description. Every MCP client currently sees the server description string as the version, and receives no instructions at all.
The fix passes both explicitly:
Relation to other PRs
#326/#331 propose the minimal variant (move description to instructions, leave version unset). This PR is the more complete fix since it also populates version correctly. If this lands, #331 can be reduced to just its dependency-cap change.
Verification
Credit to @syf2211 for the original report and patch in #317.