Repository navigation
Give the Nat type a different Lean name in the extract - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refers to #2.
The
extractjob on main fails since #23. Aeneas binds itsFueltype to the Lean nameNat, and theNattype ofrulean-natgets the same name. Aeneas then writes partial Lean files and stops with an error.This change gives the type the Lean name
BigNatwith#[aeneas::rename]. The attribute and theregister_toolline are behindcfg(rulean_extract), and onlyscripts/extract.shsets this cfg, throughRUSTFLAGS. So a normal build on stable Rust does not see them, and the Rust name staysNat.RUSTFLAGSgoes to every crate of the build, sorulean-storeandrulean-formatsee the same name asrulean-nat.The workspace lints declare the cfg, so
unexpected_cfgsdoes not warn.Tests: a nightly build of
rulean-storeandrulean-formatwith--cfg rulean_extractpasses. Theextractjob of this PR is the real test.