Repository navigation
build(release): move version and changelog prep to release time - #325
Conversation
|
Active source owner: company Native11 ( The correction must let the generated release PR pass while rejecting feature version/changelog edits, compare feature changes against the merge base, and use the maintained action versions compatible with pnpm 12. Prove the real prepare → verify flow. Root owns the separate 0.59.0 publisher at |
|
Source ownership transferred to Discovery ( Discovery: finish the guard/action-version corrections and real prepare → verify proof, obtain independent review, and merge normally. Root retains package publication; Native16 retains #323. |
drewstone
left a comment
There was a problem hiding this comment.
Reviewed exact source b91f688, including the independent review of the final guard and release workflow.
The original generated-release failure is corrected. Feature version checks now use the common ancestor, while release validation uses current main. The actual 0.59.0 -> 0.59.1 preparation/guard path passed in a disposable current-source clone. All 13 baseline controls plus five divergent-history assertions have their expected outcomes under Node22.23.2, with originals shown failing in the intended ways. Hosted Verify36376129865 passed all source and packed-release checks on this exact head.
Release notes are an explicit snapshot. Their freshness remains a documented release-cut review, and no package publishing or hosted preparation dispatch is claimed here. No remaining blocking source finding.
What changed
main.Verified source
Source:
b91f68854827a1ebaff31cd23a01f1f7acea59eb.Guard blob:
f4ce94ef3ee15b3360fb7dbef530a3053ed8f220.Current
mainwas merged before the final checks.An independent source review found no remaining blocker.
Complete hosted Verify passed on this source.
It includes type checking, the full source suite, packed-release validation, and consumer packaging.
Actual preparation and regression evidence
On Linux with Node 22.23.2, the actual scripts prepared
0.59.1from this candidate in a disposable clone.The clone modeled this candidate as the post-merge
origin/main.The generated local commit changed only
package.jsonandCHANGELOG.md, and the actual release guard accepted it.The final guard passed all 13 baseline controls, including generated patch, minor, and major releases and eight invalid-edit cases.
Five additional assertions used a real divergent Git history.
They reproduced both intermediate defects: rejecting an unchanged feature after a main release, and accepting a feature version edit matching that later release.
The corrected guard accepted the unchanged feature and rejected both feature metadata edits against the common ancestor.
Both the complete control harness and divergent-history harness returned exit 0.
Root reran these controls with Node 22.23.2.
No new checked-in unit test suite was added.
Retained evidence on GTR:
/tmp/operator-integrations325-fix/.The terminal proof is
media/merge-source/terminal.log; the Node 22 controls areproof-run-LrDZaJ/receipt.json.Local copies are under
/tmp/operator-status-20260927T0355Z/execution/on the operator Mac.Boundaries
This proof did not dispatch the new GitHub preparation workflow, push a release ref, tag a version, or publish a package.
Generated notes describe the preparation-time source snapshot.
The release owner must compare them with final release commits before merging if
mainadvances.If a branch push succeeds but PR creation fails, create the PR from that existing branch; rerunning preparation needs manual recovery.
Package publication remains with the existing release owner and its authorization.