You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Managed issue workers watch their PR by default #441
From #425 item 8 (P1). Owner chose this on 2026-11-17.
Problem
watch_pull_request and PullRequestWatchReactor run only when an agent is told to watch. Each managed worker that opens a PR has to be asked to babysit it.
Proposal
When a managed issue implementor opens or links a PR, start a watch on it by default: fix check failures, address review comments, and report when the PR is ready. The worker or its parent can still unwatch. Prefer a policy change in the managed worker path or its instructions over new machinery.
Constraints
Keep the existing rule that delegated children never watch: see the pull-request linking instructions. Settle who owns the watch (the worker's own thread, or the managed policy on the worker's behalf) before coding, and record that decision here.
GitHub Actions are off in this fork, so "checks" may mean only review bots. Don't wake on checks that never run.
The managed issue policy will start the existing pull request watch on the implementor’s behalf. The watch is stored on the worker’s thread so review updates wake that worker. The shared PR-link command covers both shell-created PRs and explicit links. Delegated children still cannot call watch_pull_request, and stopping a watch leaves the PR linked. For this fork, an empty check list counts as no checks expected. Actual results from review bots still count.
The managed policy starts the watch on the worker’s thread when it opens or links a PR. Review comments wake that worker. Delegated children still cannot start watches themselves, and either the worker or its parent can stop the watch. In this fork, an empty check list produces no wake. Checks that actually report still count.
The focused regression test failed on main and passed with the fix. vp run check:changed passed all 266 tests on Node 26.13.1, and the server typecheck reported 0 errors. The model eval built in dry-run mode. A live eval required credentials unavailable in this environment.
PR #493, head 47bfb320ea25540dd082359b03d36595c21472a5, checks and reviews: local checks passed, GitHub checks disabled, review pending.
Managed workers now get a watch for open PRs already linked to their thread, including discovered stack layers. Relinking keeps one watch per PR, and an explicit unwatch survives relinking and sync.
A managed parent can stop a watch on its direct child’s thread. Delegated children still cannot start watches themselves.
Both regression tests failed on 47bfb320ea for the reported reasons and passed with the fixes. I removed the baseline worktree. On the pushed head, vp run check:changed passed all 332 tests, and the server typecheck reported 0 errors.
PR #493, head 4dbcd30f23e830ba0699afb6947b60731a2e2d1e, checks and reviews: local checks passed, GitHub Actions disabled, review pending.
Issue: #441 Managed issue workers watch their PR by default
Thread: thread:delegated-task:command%3Amcp%3A1c7a0818-d28c-48a9-813c-8d5ee81383d6%3Adelegate-task%3Aimplement-441
Model: gpt-6.2-sol
Branch: issue-441-managed-issue-workers-watch-their-pr-by
Completed: 2026-11-20T00:37:01.655Z
Pushed the final fix to draft PR #493. A PR linked after its managed worker stops now records the same ended-watch state as an explicit unwatch. The shared backfill rule skips that link, so unchanged reads leave syncedAt alone.
The regression failed on 4dbcd30f23 because the second sync advanced syncedAt by one minute. All four focused tests passed with the fix, and the baseline worktree was removed.
vp run check:changed passed with 333 tests. The apps/server typecheck reported 0 errors.
PR #493, head 39757a31a06de99b3ce69db52a6f880956084728, checks and reviews: GitHub Actions disabled, no review on this head yet.
Activity
tannerpolley commentedon Nov 19, 2026
T3 Code status: Unavailable
Issue: #441 Managed issue workers watch their PR by default
Thread: thread:delegated-task:command%3Amcp%3A1c7a0818-d28c-48a9-813c-8d5ee81383d6%3Adelegate-task%3Aimplement-441
Model: gpt-6.2-sol
Branch: issue-441-managed-issue-workers-watch-their-pr-by
Updated: 2026-11-20T00:40:27.407Z
tannerpolley commentedon Nov 19, 2026
The managed issue policy will start the existing pull request watch on the implementor’s behalf. The watch is stored on the worker’s thread so review updates wake that worker. The shared PR-link command covers both shell-created PRs and explicit links. Delegated children still cannot call
watch_pull_request, and stopping a watch leaves the PR linked. For this fork, an empty check list counts as no checks expected. Actual results from review bots still count.tannerpolley commentedon Nov 19, 2026
T3 Code closeout: done
Issue: #441 Managed issue workers watch their PR by default
Thread: thread:delegated-task:command%3Amcp%3A1c7a0818-d28c-48a9-813c-8d5ee81383d6%3Adelegate-task%3Aimplement-441
Model: gpt-6.2-sol
Branch: issue-441-managed-issue-workers-watch-their-pr-by
Completed: 2026-11-19T23:24:36.426Z
Opened draft PR #493 against
main. It closes #441 on merge.The managed policy starts the watch on the worker’s thread when it opens or links a PR. Review comments wake that worker. Delegated children still cannot start watches themselves, and either the worker or its parent can stop the watch. In this fork, an empty check list produces no wake. Checks that actually report still count.
The focused regression test failed on
mainand passed with the fix.vp run check:changedpassed all 266 tests on Node 26.13.1, and the server typecheck reported 0 errors. The model eval built in dry-run mode. A live eval required credentials unavailable in this environment.PR #493, head
47bfb320ea25540dd082359b03d36595c21472a5, checks and reviews: local checks passed, GitHub checks disabled, review pending.tannerpolley commentedon Nov 20, 2026
T3 Code closeout: done
Issue: #441 Managed issue workers watch their PR by default
Thread: thread:delegated-task:command%3Amcp%3A1c7a0818-d28c-48a9-813c-8d5ee81383d6%3Adelegate-task%3Aimplement-441
Model: gpt-6.2-sol
Branch: issue-441-managed-issue-workers-watch-their-pr-by
Completed: 2026-11-20T00:15:23.352Z
Pushed both round-one fixes to draft PR #493.
Both regression tests failed on
47bfb320eafor the reported reasons and passed with the fixes. I removed the baseline worktree. On the pushed head,vp run check:changedpassed all 332 tests, and the server typecheck reported 0 errors.PR #493, head
4dbcd30f23e830ba0699afb6947b60731a2e2d1e, checks and reviews: local checks passed, GitHub Actions disabled, review pending.tannerpolley commentedon Nov 20, 2026
T3 Code closeout: done
Issue: #441 Managed issue workers watch their PR by default
Thread: thread:delegated-task:command%3Amcp%3A1c7a0818-d28c-48a9-813c-8d5ee81383d6%3Adelegate-task%3Aimplement-441
Model: gpt-6.2-sol
Branch: issue-441-managed-issue-workers-watch-their-pr-by
Completed: 2026-11-20T00:37:01.655Z
Pushed the final fix to draft PR #493. A PR linked after its managed worker stops now records the same ended-watch state as an explicit unwatch. The shared backfill rule skips that link, so unchanged reads leave
syncedAtalone.4dbcd30f23because the second sync advancedsyncedAtby one minute. All four focused tests passed with the fix, and the baseline worktree was removed.vp run check:changedpassed with 333 tests. Theapps/servertypecheck reported 0 errors.PR #493, head
39757a31a06de99b3ce69db52a6f880956084728, checks and reviews: GitHub Actions disabled, no review on this head yet.