Skip to content

chore(sync): merge upstream nightly 20261116.4800 - #428

Merged
tannerpolley merged 1424 commits into
mainfrom
sync/upstream-2026-11-16
Nov 17, 2026
Merged

tannerpolley merged 1424 commits into
mainfrom
sync/upstream-2026-11-16

Conversation

@tannerpolley

@tannerpolley tannerpolley commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Summary

The fork is behind v0.1.10-nightly.20261116.4800. This sync needs to preserve fork behavior while adopting the upstream changes and retaining their ancestry. Closes #417.

d9c88282 (fork base) ─┐
7d32075e (nightly) ──┴─ real merge on sync/upstream-2026-11-16

Keep project sections, issue admission/ownership, delegated cancellation/completion/questions, Writer routing, recovery policy, artifacts/PDF review and notebook execution. Adopt upstream selective reads, session release cleanup, worktree reservations/cancellation, title feedback and viewer refresh behavior where equivalent. Resolve the old fork turn-item-count cache collision with upstream migration 85 while preserving both migration ledgers.

The behavior replacement ledger and complete lost-code audit judge all 82 flagged hunks and both replaced fork helpers. No product behavior is retired. Correct the false daily-sync claim in the fork guide. The new issue-vouch.yml job is disabled in source with if: false. GitHub returns 404 for gh workflow disable until the file exists on the default branch; all 26 registered workflows remain disabled. Set the new workflow's GitHub disabled state after landing; the source guard prevents execution meanwhile.

Preserve this merge ancestry when landing the PR: use a merge commit, without squashing or rebasing. The sync branch also includes a normal merge of origin/main at 965235ad3c20c73cf919f4cfd7d5bd053b3903a7.

Main integration: normal merge commit 3f5fe1421f77058887ad672c040174f789c491b4 joins sync head b5a15b0991d1efd66a40a8ab9baad4c5e3319497 and origin/main at 965235ad3c20c73cf919f4cfd7d5bd053b3903a7. The sole agentContextBudget.json conflict is resolved from measurement of the combined tree. #427’s queueNote and limit-ask instruction are present; the sidebar effort fixes are included.

Scope

Only #417 and conflict integration needed by this nightly. The #418–#422 refactors remain separate. Mobile is out of scope.

Evidence

Completion review fixes at 8d1140ebc53587560c9cef159483efe9f22428ed retain the spawning run and thread-owned managed-worker deliveries in the selective reader, and restore upstream's follow-up hold inside the fork result selector.

  • Before: the fork selector omitted untagged grandchild-completion wakes and could close a follow-up using its earlier terminal turn while that wake still ran. This was lost upstream behavior from fix(server): a follow-up delegated task waits for the subagents its child starts pingdotgg/t3code#34958 (daed1dd327), present from the initial sync; calling it pre-existing was incorrect.
    After: upstream delegatedTaskRuns selects the task's turns and descendant wakes before fork promotion/recovery mapping; delegatedTaskAwaitsWork also protects the pending-result query. Upstream's test remains byte-for-byte unchanged.

  • Both earlier cohort regressions and the restored upstream hold pass: 128 tests / 7 completion, recovery and Writer-routing files. The prior 127-pass/1-fail result is superseded.

  • The agent-context registration gate from that incremental check is resolved by the MCP follow-up below.

  • The full sync check at 02f797b95b reported only the three known mobile type errors and a 900-second timeout for 1,182 adjacent-test files; its other phases passed. That broader test batch remains unverified.

MCP registration follow-up at b5a15b0991d1efd66a40a8ab9baad4c5e3319497:

  • Before: upstream #32764 rejects caller-bound tools without the outside-client visibility annotation. Production MCP layer construction hits the same invariant as the budget test, so this was a runtime sync regression.
    After: nine fork tools declare upstream hiddenFromOutsideClients through McpSchema.EnabledWhen; registration succeeds and outside clients cannot discover/call those tools. The guard and handler authority checks remain intact.
  • Update fork toolkit tests for upstream's hidden-tool error, explicit forward paging and final-chunk completion acknowledgement. Preserve prompt-only/truncated-read safeguards, and wait for persisted running events before testing running-task cancellation instead of assuming async admission has reached that phase.
  • Measured budget: Claude 6,729, Codex 8,122, MCP tool-list JSON 79,244 bytes. Tool descriptions and model-facing schemas are unchanged by this fix.
  • All 240 tests / 25 files pass in one consolidated run: AgentContextBudget.test.ts, every toolkit test (including toolkits/core.test.ts), both orchestrator toolkit integration suites, device toolkit, HTTP transport, tool access/races, invocation context and advertised JSON schemas.
  • vp run check:changed 8d1140ebc53587560c9cef159483efe9f22428ed --concurrency "$AGENT_HEAVY_CORES" passes every step for this follow-up: format, lint, both Knip passes, GraphQL, all three affected package typechecks and 11 tests / 4 files. The previous MCP registration/budget gate is resolved. The earlier full-sync adjacent-test timeout remains historical, broader unverified coverage.

Combined-tree verification at 3f5fe1421f77058887ad672c040174f789c491b4:

  • Measured budget: Claude 6,729 bytes; Codex 8,122 bytes; MCP tool-list JSON 79,439 bytes. These combined-tree values supersede the pre-main-merge measurement above.
  • The read-only admission test accepts starting or running for admitted readers; the fifth reader remains strictly queued, with the exact full-pool note checked. This matches the merged upstream task-status reporting without changing admission behavior.
  • Additional adjacent-test failures are resolved: two fixtures now implement the child-shell read used by fork completion progress, restoring all three wait-budget subscriptions. Upstream #31905 (35b88636d4) model-refusal guidance is shared by requireAdvertisedModel and the fork target validator; provider, role-order and option checks remain unchanged. The bounded suggested-model list and update-required CLI guidance are preserved.
  • The five requested files pass (82 tests); the expanded focused run passes 205 tests / 8 files, including both MCP service suites and project-handler tests. Server and web vp run typecheck both pass.
  • vp run check:changed b5a15b0991d1efd66a40a8ab9baad4c5e3319497 --concurrency "$AGENT_HEAVY_CORES" passes format, lint, both Knip passes, GraphQL, 165 adjacent tests / 12 files and React Compiler checks for both changed web files. Its broad package typecheck reports only the three known mobile errors; server and web are independently green. The five MCP service failures from the first combined-tree run are resolved.

Initial sync validation at 721ba11236c73ef1da0722bc4cff89fca5243716:

  • Server, web, contracts and desktop vp run typecheck: all four pass.
  • Focused persistence/storage/SQLite/notebook tests: 335 pass in 7 files.
  • Focused issue ownership, delegation, Writer, workspace preparation, silent wake, artifacts and fork VCS tests: 147 pass in 11 files.
  • Frontend project sections, PDF review/viewer, notebook preview, composer transfer, title feedback and actions: 133 pass in 10 files.
  • Disposable empty database: upstream migrations 1–96 and fork migrations 1–30 apply; reopening is idempotent; PRAGMA integrity_check returns ok. The live database was not read, copied or written.
  • Initial merge-tree: 129 conflicted files / 272 blocks; whitespace-aware reconciliation: 117 files / 262 blocks. rerere recorded the resolutions.
  • Focused runtime/provider-session/usage-limit recovery tests: 140 pass in 4 files, including the fork release-cleanup cases. Total focused proof: 755 tests in 32 files.
  • check:changed: format, lint, both Knip passes, GraphQL generation, dependency patches, 41 script tests and React Compiler coverage (697 files) pass. Package typechecking reports exactly the three known mobile errors. The 1,181-file adjacent-test batch reaches the runner's 900-second ceiling and is stopped; this broader batch is not verified. Focused proof above and the four explicitly requested package typechecks pass.

Integrated client verification and independent review remain for the primary agent. No development server or paid provider turn was started by this implementor.

Merge Danger

Door: database upgrades require a backup to roll back to an older release.

Blast Radius: broad. This imports the selected upstream nightly across the shared server, clients and contracts; the ledger records preservation decisions for the fork seams.

Implemented with GPT-6.1 Sol in the Codex harness through T3 Code.

bentbrain and others added 30 commits November 15, 2026 05:17
Co-authored-by: bentbrain <28818884+bentbrain@users.noreply.github.com>
…tgg#30753)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
…gdotgg#29749)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
… reply (pingdotgg#30084)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…tgg#32376)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…on every host (pingdotgg#32774)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: GPT-6.1 Sol <noreply@openai.com>
Co-authored-by: Shivam Sharma <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…failed when one did (pingdotgg#32407)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ted (pingdotgg#32413)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…pingdotgg#32323)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…s cancelled (pingdotgg#32414)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ngdotgg#33083)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ing node_modules (2,500 s → 5.0 s) (pingdotgg#32023)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…iew (pingdotgg#32324)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…y never show (pingdotgg#32351)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…dotgg#32364)

Co-authored-by: azhar <azhar.amir@amartha.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…33069)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#32598)

Co-authored-by: Zuri <zurih@rtx.internal>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…d player item (pingdotgg#32196)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…tgg#33078)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…pingdotgg#32619)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ad read instead of hiding its threads (pingdotgg#32620)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ngdotgg#32683)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge and others added 16 commits November 16, 2026 08:49
Co-authored-by: Julius Marminge <julius0216@outlook.com>
… keep uploading (pingdotgg#37681)

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
)

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Marker-bit <Marker-bit@users.noreply.github.com>
…gdotgg#37703)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: screen <screen@users.noreply.git.cafe>
Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ead (pingdotgg#37735)

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ingdotgg#37741)

Co-authored-by: Usama Khan <usama@Usamas-MacBook-Pro.local>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Merge v0.1.10-nightly.20261116.4800 with fork issue ownership,
project organization, Writer routing, artifacts/PDF and notebook behavior.
Keep upstream ancestry and record behavior replacements on #417.

Closes #417
Keep the spawning run in selective completion projections and load
thread-owned delivery records for runless managed admissions.

Prove second-child coalescing for both cohort owners before acceptance.
@tannerpolley
tannerpolley marked this pull request as ready for review November 17, 2026 00:11
@tannerpolley
tannerpolley merged commit 7abb7f1 into main Nov 17, 2026
@tannerpolley
tannerpolley deleted the sync/upstream-2026-11-16 branch November 17, 2026 00:11
tannerpolley added a commit that referenced this pull request Nov 17, 2026
…erge dropped

The sync merge 721ba11 (#428) kept fork code where upstream had narrowed
reads, and dropped one fork test isolation, so 14 server tests failed on main:

- FoundationPersistence: a fork test lost Layer.fresh, so its run.silence.check
  effects leaked into later shared-database tests.
- control-reads: delegated tasks read the parent's whole history again
  (upstream getRunProviderRecords, subagentChildThreadIds and run-scoped
  completion delivery reads were dropped); fork continueAdmissions and
  EndedRunTurnItems walked the thread.
- ProjectionStore.fork: the subagent usage-limit lookup lost its partial index
  to upstream's new type index; two fork tests asserted fork-only details
  upstream replaced (archived_at column, type-index plan).

Closes #449

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sync with upstream nightly v0.1.10-nightly.20261116.4800, with a behavior replacement ledger