Skip to content

fix: resolve the test failures tracked in issue 470 - #519

Merged
tannerpolley merged 2 commits into
mainfrom
issue-470-16-tests-already-fail-on-main-in-files
Nov 20, 2026
Merged

tannerpolley merged 2 commits into
mainfrom
issue-470-16-tests-already-fail-on-main-in-files

Conversation

@tannerpolley

Copy link
Copy Markdown
Owner

Summary

Clean main after #469 still failed the 16 cases tracked in #470 and two web follow-ups.

Area Change
Claude Preserve the launching tool item and source thread when the monitor roster refreshes, as upstream does. Remove duplicate fork cases and their unused harness.
Codex Expect both managed roles to expose delegate_task through the direct tool server, as required since 467ec62e08.
Provider startup and runtime Supply the new baseline hook and a valid worktree fixture. Synchronize the deletion and question-wake tests on the operations they exercise.
Desktop preview and scheduled tasks Close only the tabs captured before unloading, matching upstream. Use the generic dispatch error for a blank refusal cause.
ACP registry and Antigravity Let the replay harness generate the steering runtime notes. Wait for initialization before the mock executable aborts and assert the 4 KiB page-size message.
Inline terminal and web Isolate shell lookup and have the fake terminal exit on kill. Match current issue-host support and double-click selection behavior.

Evidence

  • Before — reproduced all 18 tracked failures in a clean worktree at d8fdc0478951. The worktree was removed after the run.
  • After — 889 tests passed across the 11 targeted files with Node 26.13.1 and GIT_CONFIG_GLOBAL=/dev/null. The server and web type checks passed. vp run check:changed passed with 797 tests across its 13 selected files.

Merge Danger

Reversible. Runtime changes affect Claude’s monitor details, desktop tab closure, and dispatch error messages. Mobile type errors remain outside the issue’s implementation scope.

Closes #470

GPT-6.2 Sol via Codex in T3 Code

Keep Claude monitor origins and newly opened preview tabs during roster refresh and desktop unload. Fall back to a generic refusal message for blank dispatch causes. Bring provider, orchestration, terminal, and web test fixtures in line with the behavior they cover.
Let the browser select individual words in both inline-code renderers, including the fork’s click-to-copy component. Treat whitespace-only dispatch details as missing and cover the persisted refusal fallback.
@tannerpolley
tannerpolley marked this pull request as ready for review November 20, 2026 23:18
@tannerpolley
tannerpolley merged commit 0344ee0 into main Nov 20, 2026
@tannerpolley
tannerpolley deleted the issue-470-16-tests-already-fail-on-main-in-files branch November 20, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

16 tests already fail on main in files check:changed rarely selects

1 participant