Repository navigation
sprintf-js を依存ツリーから除去 (GHSA-hp3w-g68c-fv3c 対応) - #54
Merged
Merged
Conversation
sprintf-js <=1.1.3 (GHSA-hp3w-g68c-fv3c) has no patched release, so upgrade of sprintf-js itself is impossible. It was pulled in via @istanbuljs/load-nyc-config -> js-yaml 3 -> argparse 1 -> sprintf-js. Pin js-yaml to ^4 for @istanbuljs/load-nyc-config through npm overrides, which drops argparse 1 and sprintf-js from the tree. Verified: npm ls sprintf-js is empty; jest suites (js and mjs) pass, including pretest lint/format checks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependabot アラート対応です。
sprintf-js の脆弱性（GHSA-hp3w-g68c-fv3c、対象 <=1.1.3）には修正版リリースが存在しないため、sprintf-js 自体のアップグレードでは直せません。依存ツリーから外す方法を取りました。
経路:
@istanbuljs/load-nyc-config→ js-yaml 3系 → argparse 1系 → sprintf-js 1.0.3対応: package.json に npm
overridesを追加し、@istanbuljs/load-nyc-config配下の js-yaml のみ ^4 に差し替えました。これにより argparse 1系と sprintf-js がツリーから消えます。検証:
npm ls sprintf-js: emptynpm test（pretest の lint / format check を含む）とnpm run test:mjs: 全て通過