Repository navigation
fix: classify unconfirmed JDBC transactions as outcome unknown - #236
Draft
philipgreat wants to merge 4 commits into
Draft
philipgreat wants to merge 4 commits into
philipgreat wants to merge 4 commits into
Conversation
This was referenced Oct 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #235. Review-only P1 follow-up stacked on #234, itself stacked on the integrated Committed Mutation candidate. Do not merge this directly into main or bypass the #216 formal chain and #225 audit API decision.
A commit acknowledgement may be lost after durable business-row and Outbox commit. Conversely, restoring autoCommit(true) after an unconfirmed rollback can implicitly commit pending writes. This change reports a sanitized TRANSACTION_OUTCOME_UNKNOWN result, fences the affected mutation ledger before replay, and skips autoCommit restoration when rollback is unconfirmed. A confirmed commit followed only by cleanup faults remains a committed success.
RED/GREEN real-SQLite probes now cover JDBC commit and rollback throwing Error, including an Error with suppressed diagnostics disabled, and a commit failure followed by rollback Error. They also cover a user logging handler throwing Error after confirmed commit. The same graph cannot be blindly retried; a separate graph remains saveable. The original business/JDBC Error is rethrown only after the ledger is fenced where the provider carries it. Operational warnings do not include JDBC diagnostic text.
At exact head edbae2b: GraphTraceSqliteTest passes 44/44 and JdbcCommittedCleanupSqliteTest passes 6/6 in the PR worktree. The affected Maven reactor exits zero. The exact-head examples CI passes. A clean 21-artifact internal Maven package passes immutable publication and a two-round Committed consumer; downloaded-JAR fault suites pass 44+6 twice. The fixed generated Customer application passes save/Q/E twice against this exact internal version with 21 generated library source files unchanged. Current evidence is tracked in teaql-conformance PR #174. Earlier dd32106 and dee5bbe receipts are historical.
This does not determine whether a failed commit actually committed. Applications must reconcile durable business rows and Outbox before a new attempt. Human review, formal-chain integration, non-SQLite fault injection and public release remain open.