Repository navigation
fix(core): make identity creation-only and version updates internal - #269
Open
philipgreat wants to merge 2 commits into
Open
philipgreat wants to merge 2 commits into
philipgreat wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Application code could change entity identity and version through inherited
BaseEntity.updateId/updateVersion, and identity could also be rewritten through E expressions. Make these ordinary update methods package-private, remove the expression identity writer, and add stagedExecutableRequest.newEntityWithId(id, context)for validated creation-time identity input. The ID allocation floor is reserved through InternalIdGenerationService before trusted context initialization; missing/unsupported reservation fails closed. The ID is installed before initializers; it cannot initialize an already identified entity.Keep framework hydration/readback and the existing optimistic update/delete version transitions. Update framework fixtures to hydrate system fields through their internal path. This is paired with https://github.com/teaql/teaql-code-gen/pull/302; callers should migrate to Q creation or query-loaded entities. No public compatibility aliases are retained.
Validation: all 282 Java core tests passed; 29 runtime and 8 Jackson tests passed through the dependent reactor, including TFP test compilation. An external-package javac probe accepts the new creation API and rejects calls to both ordinary system updaters. Diff whitespace checks pass. No release artifacts were published.