feat: split CLI into smartwrap-cli so core installs without yargs - #24
Open
tecfu wants to merge 1 commit into
Open
feat: split CLI into smartwrap-cli so core installs without yargs#24tecfu wants to merge 1 commit into
tecfu wants to merge 1 commit into
Conversation
Resolves #19: library consumers can install only the core package without pulling in yargs or the CLI binary. - smartwrap (root): core library only — breakword, strip-ansi, wcwidth - packages/smartwrap-cli: separate package providing the `smartwrap` bin and depending on smartwrap + yargs - Update README with install matrix and migration notes - Remove bin field from the core package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #19.
Library users who only need text wrapping no longer have to install
yargsor the CLI binary.npm install smartwrapnpm install -g smartwrap-clipackages/smartwrap-clismartwrapbinary + yargsSame repository; two publishable packages. No second remote/repo.
Details
binandyargsfrom the corepackage.jsonsrc/terminal-adapter.js→packages/smartwrap-cli/src/smartwrap+yargsThis branch is based on
modernize-v3(#23), so it also includes the Node 12+ modernization, dependency cleanup, and CI updates from that PR.Test plan
npm test(25 passing) on core packagedependenciesare onlybreakword,strip-ansi,wcwidthbinfieldsmartwrap@3thensmartwrap-cli@3npm install smartwrapdoes not install yargsnpm install -g smartwrap-cliprovides workingsmartwrapbinary