feat(search)!: Report coverage and return empty search results - #30
Merged
Merged
Conversation
Propagate cancellation instead of swallowing it as an unavailable collection. Preserve successful matches and report incomplete coverage on stderr. BREAKING CHANGE: Searches with no matches now succeed with an empty result instead of exiting with an error.
philprime
marked this pull request as ready for review
September 24, 2026 18:08
philprime
enabled auto-merge (squash)
September 24, 2026 18:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract the search improvements from
feature/tuiwithout adding browser or terminal dependencies. Cancellation now propagates, successful matches survive unavailable collections, and incomplete coverage is reported on stderr.Compatibility
Searches with no matches now succeed with an empty JSON array or an explicit human-readable message instead of exiting with an error. Result arrays keep their existing fields.
Verification
Focused regression tests,
make test,make analyze, andmake buildpassed. The release CLI returned a successful empty array for a live no-match search in Swift.