Conversation
…and check-jsonschema - Add `annotations_enabled` (default `true`) to the three remaining check actions on the same pattern as validate, tflint, and actionlint - `terraform.fmt` reads the file and hunk line from the diff it captured; `terraform.docs` reads the stale file from its `is out of date` line; both prefix `target_dir` since the tools print module-relative paths - `github-actions.check-jsonschema` re-runs with `--output-format json`; schema validation has no line numbers, so the annotation points at the file and names the failing JSON path
GitHub Actions Integration
✅ All 1 passed. |
Member
Author
|
Verified on ubuntu-latest (run 35524249993) with the actions from #26: terraform fmt annotates the first line of each hunk in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary PR for the annotations added in the fmt/docs/check-jsonschema PR. The fixtures fail on purpose: an unformatted module with a subdirectory (terraform fmt, two hunks), stale READMEs in recursive mode (terraform-docs), a workflow with a non-list steps and an action without a description (check-jsonschema). Will be closed after the run.