fix(workflows): restore the github-actions.integration reusable workflow - #32
Merged
Merged
Conversation
…ml via Terraform" This reverts 793fe44, which replaced this repository's reusable lint workflow with a caller that calls itself. It lost `on: workflow_call`, so it and `github-actions.yaml`, the caller that calls it, have both failed at startup since: no actionlint and no check-jsonschema has run on `main` or on any open pull request. The file is restored byte for byte to its state at bef73f1. The provisioning that overwrote it is fixed in tedilabs/github#35, which renames the common file to `github-actions.yaml`, the caller it actually is. That apply deletes this path before it stops managing it, so it has to land first, or it takes this restore with it.
👋 Welcome! Looks like this is your first pull request.Hey, thanks for your contribution! Please give us a bit of time to review it. 😄 Please check out our contributing guidelines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Background
793fe44(chore: update .github/workflows/github-actions.integration.yaml via Terraform) replaced this repository's reusable lint workflow with a copy of the caller, so the file now ends in:which is itself. It no longer has
on: workflow_call, so it andgithub-actions.yaml— the caller that calls it — both fail at startup. No actionlint and no check-jsonschema has run onmainor on any open pull request since, including #1, #5, #30, and #31.mainfails this way at793fe44and succeeded at2899f46, so the provisioning is the cause, not anything in the repository.🔗 Related Issues
⚙️ Description
Restore
.github/workflows/github-actions.integration.yamlbyte for byte to its state atbef73f1, the last commit that changed it on purpose (feat(actions)!: align actionlint with the other check actions, #13).Nothing else changes.
github-actions.yamlalready calls this workflow and starts working again the moment it is back.tedilabs/github#35 renames the common file so it stops writing to this path. Because
github_repository_filedeletes the file when the resource is destroyed, that apply deletes this path before it stops managing it.So: apply tedilabs/github#35 first, then merge this. The other way round, the apply removes the restored workflow again and
maingoes back to failing.✅ Verification
bef73f1(diffclean).yamllint,actionlint, andcheck-jsonschema(vendor.github-workflows) pass on it locally — which is the only way to run them at the moment, since the workflow that normally does is the one being restored.